Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal Structs class with google-cloud-core version #1492

Closed
kolea2 opened this issue Dec 5, 2023 · 1 comment · Fixed by #1501
Closed

Replace internal Structs class with google-cloud-core version #1492

kolea2 opened this issue Dec 5, 2023 · 1 comment · Fixed by #1501
Assignees
@cindy-peng
Labels
api: logging Issues related to the googleapis/java-logging API. type: cleanup An internal cleanup or hygiene concern.

Comments

@kolea2
Copy link
Contributor

kolea2 commented Dec 5, 2023

Just merged in googleapis/sdk-platform-java#2278, once it is released we should swap out any usages of https://github.com/googleapis/java-logging/blob/main/google-cloud-logging/src/main/java/com/google/cloud/logging/Structs.java with this upstream version instead.
@kolea2 kolea2 added the type: cleanup An internal cleanup or hygiene concern. label Dec 5, 2023
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Dec 5, 2023
@cindy-peng
Copy link
Contributor

Looks like currently the change for google-cloud-core is still pending for release: googleapis/sdk-platform-java#2290

Will start the swap once the change has been released.

@cindy-peng cindy-peng mentioned this issue Jan 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/java-logging API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Replace internal Structs class with google-cloud-core version googleapis/java-logging
3 participants
@daniel-sanche @kolea2 @cindy-peng