Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat: removing migrated grpc- and proto- modules from repository #592

Merged
merged 12 commits into from
Jan 10, 2023
Merged

feat: removing migrated grpc- and proto- modules from repository #592

merged 12 commits into from
Jan 10, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 10, 2023 •
edited
Loading

The proto- and grpc- modules have been migrated to
https://github.com/googleapis/gapic-generator-java/tree/main/java-iam

@suztomo suztomo requested a review from a team as a code owner January 10, 2023 15:19
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 10, 2023
@generated-files-bot
Copy link

generated-files-bot bot commented Jan 10, 2023 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/release/publish_javadoc.sh
  • .kokoro/release/publish_javadoc11.sh
  • grpc-google-iam-v1/src/main/java/com/google/iam/v1/IAMPolicyGrpc.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/AuditConfigDelta.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/AuditConfigDeltaOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/Binding.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/BindingDelta.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/BindingDeltaOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/BindingOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/GetIamPolicyRequest.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/GetIamPolicyRequestOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/GetPolicyOptions.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/GetPolicyOptionsOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/IamPolicyProto.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/OptionsProto.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/Policy.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/PolicyDelta.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/PolicyDeltaOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/PolicyOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/PolicyProto.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/SetIamPolicyRequest.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/SetIamPolicyRequestOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/TestIamPermissionsRequest.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/TestIamPermissionsRequestOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/TestIamPermissionsResponse.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/TestIamPermissionsResponseOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/logging/AuditData.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/logging/AuditDataOrBuilder.java
  • proto-google-iam-v1/src/main/java/com/google/iam/v1/logging/AuditDataProto.java
  • renovate.json

@product-auto-label product-auto-label bot added the api: iam Issues related to the googleapis/java-iam API. label Jan 10, 2023
@suztomo suztomo changed the title chore: removed migrated grpc- and proto- modules chore: removing migrated grpc- and proto- modules Jan 10, 2023
@suztomo suztomo force-pushed the remove_moved_artifacts branch from e05da1b to 7d42924 Compare January 10, 2023 15:36
suztomo
suztomo commented Jan 10, 2023
View reviewed changes
.repo-metadata.json
@@ -11,7 +11,7 @@
"repo": "googleapis/java-iam",
"repo_short": "java-iam",
"library_type": "OTHER",
"distribution_name": "com.google.api.grpc:proto-google-iam-v1",
"distribution_name": "com.google.cloud:google-iam-policy",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memo: OwlBot Postprocessor modifies versions.txt and other files based on repo-metadata.json.

https://github.com/googleapis/synthtool/blob/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a/docker/owlbot/java/src/fix-poms.py#L279

@suztomo suztomo requested a review from ddixit14 January 10, 2023 15:47
suztomo
suztomo commented Jan 10, 2023
View reviewed changes
.kokoro/release/publish_javadoc.sh
@@ -33,7 +33,7 @@ python3 -m pip install --require-hashes -r .kokoro/requirements.txt
# compile all packages
mvn clean install -B -q -DskipTests=true

export NAME=proto-google-iam-v1
export NAME=google-iam-policy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwlBot PostProcessor made this change, based on the repo-metadata.json change.

.kokoro/release/publish_javadoc11.sh
@@ -33,7 +33,7 @@ python3 -m pip install --require-hashes -r .kokoro/requirements.txt
# compile all packages
mvn clean install -B -q -DskipTests=true

export NAME=proto-google-iam-v1
export NAME=google-iam-policy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwlBot PostProcessor made this change, based on the repo-metadata.json change.

@suztomo suztomo changed the title chore: removing migrated grpc- and proto- modules feat: removing migrated grpc- and proto- modules from repository Jan 10, 2023
suztomo
suztomo commented Jan 10, 2023
View reviewed changes
pom.xml
@@ -2,10 +2,10 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>google-iam-parent</artifactId>
<artifactId>google-iam-policy-parent</artifactId>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the artifact ID to avoid conflict with the one in gapic-generator-java/java-iam.

@suztomo suztomo merged commit 9c4b9aa into main Jan 10, 2023
@suztomo suztomo deleted the remove_moved_artifacts branch January 10, 2023 15:59
@suztomo
Copy link
Member Author

suztomo commented Jan 10, 2023

It's "feat" to make it releasable unit with a minor version bump.

@release-please release-please bot mentioned this pull request Jan 10, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 11, 2023
@release-please
chore(main): release 1.7.0 (#579)
cce93fe 
🤖 I have created a release *beep* *boop*
---


## [1.7.0](https://togithub.com/googleapis/java-iam/compare/v1.6.23...v1.7.0) (2023-01-10)


### Features

* Removing migrated grpc- and proto- modules from repository ([#592](https://togithub.com/googleapis/java-iam/issues/592)) ([9c4b9aa](https://togithub.com/googleapis/java-iam/commit/9c4b9aace04fc72868f4dcaf289eb0a8f35d4e1f))


### Bug Fixes

* Remove 'unstable API' message from README.md ([#570](https://togithub.com/googleapis/java-iam/issues/570)) ([8da89f5](https://togithub.com/googleapis/java-iam/commit/8da89f59cbe323b2cc5eb2b483485e424622b027))


### Dependencies

* Update dependency com.google.cloud:google-iam-policy to v1.6.23 ([#578](https://togithub.com/googleapis/java-iam/issues/578)) ([aa49b5e](https://togithub.com/googleapis/java-iam/commit/aa49b5efaf53fcafc0bbd7662e8b016fcfc2ff61))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ddixit14 ddixit14 ddixit14 approved these changes

Assignees
No one assigned
Labels
api: iam Issues related to the googleapis/java-iam API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @ddixit14