Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency convergence check misses non-compliance on the managed dependencies #3710

Closed
suztomo opened this issue Feb 22, 2022 · 0 comments · Fixed by #4772
Closed

Dependency convergence check misses non-compliance on the managed dependencies #3710

suztomo opened this issue Feb 22, 2022 · 0 comments · Fixed by #4772
Assignees
@suztomo
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Feb 22, 2022 •
edited
Loading

Last Friday, I was almost releasing a Google Cloud BOM version that include an incompatibility.

In #3593, I found that com.google.cloud:google-cloud-spanner-jdbc:2.5.11 depended on google-cloud-spanner 6.18.0 while the google-cloud-spanner in the BOM was 6.19.0. This was non-compliance of the convergence rule. The two are not compatible (see the compilation error in googleapis/java-spanner-jdbc#752 (comment)). However the check didn't detect the gap, because google-cloud-spanner is part of the BOM and its version was set to 6.19.0.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 23, 2022
@Neenu1995 Neenu1995 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Feb 24, 2022
@Neenu1995 Neenu1995 self-assigned this Feb 24, 2022
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 25, 2022
@Neenu1995 Neenu1995 assigned suztomo and unassigned Neenu1995 Jul 26, 2022
@suztomo suztomo mentioned this issue Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suztomo suztomo

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: assert convergence among Cloud Java client libraries suztomo/java-cloud-bom
3 participants
@suztomo @Neenu1995 @yoshi-automation