Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update default sample row key attempt timeout to 5 min #1827

Merged
merged 4 commits into from
Jun 30, 2023
Merged

fix: update default sample row key attempt timeout to 5 min #1827

merged 4 commits into from
Jun 30, 2023

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jun 29, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested a review from a team as a code owner June 29, 2023 17:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Jun 29, 2023
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 29, 2023
@mutianf mutianf changed the title fix: update default sample row key attempt timeout to 1 min fix: update default sample row key attempt timeout to 5 min Jun 30, 2023
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 30, 2023 14:50
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2f363ef into googleapis:main Jun 30, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 30, 2023
@release-please release-please bot mentioned this pull request Jun 30, 2023
Merged
@mutianf mutianf deleted the update-default branch June 30, 2023 15:27
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 17, 2023
@release-please
chore(main): release 2.25.0 (#1828)
e9b4034 
🤖 I have created a release *beep* *boop*
---


## [2.25.0](https://togithub.com/googleapis/java-bigtable/compare/v2.24.1...v2.25.0) (2023-07-14)


### Features

* Change stream retention to create and update table ([#1823](https://togithub.com/googleapis/java-bigtable/issues/1823)) ([05fca58](https://togithub.com/googleapis/java-bigtable/commit/05fca581d4225769cc581e26e679e6bca105055b))


### Bug Fixes

* Fix batch mutation limit ([#1808](https://togithub.com/googleapis/java-bigtable/issues/1808)) ([ed24d4f](https://togithub.com/googleapis/java-bigtable/commit/ed24d4fdc67c6d0af66ea055ba1ad7f7c037a361))
* Update default sample row key attempt timeout to 5 min ([#1827](https://togithub.com/googleapis/java-bigtable/issues/1827)) ([2f363ef](https://togithub.com/googleapis/java-bigtable/commit/2f363ef3636c2810c322bb5978cc586f8aec2ef2))


### Documentation

* Fix formatting for reversed order field example ([#1836](https://togithub.com/googleapis/java-bigtable/issues/1836)) ([10a0426](https://togithub.com/googleapis/java-bigtable/commit/10a0426f580b86b26541b95a778bb8b7f6562383))
* Increase the maximum retention period for a Cloud Bigtable backup from 30 days to 90 days ([#1826](https://togithub.com/googleapis/java-bigtable/issues/1826)) ([159fe38](https://togithub.com/googleapis/java-bigtable/commit/159fe3857735c9061672fc951388215edb0a324c))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.22.0 ([#1838](https://togithub.com/googleapis/java-bigtable/issues/1838)) ([fba2c49](https://togithub.com/googleapis/java-bigtable/commit/fba2c49e9e71209289497f53868aa561c0fba7a3))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 ([#1833](https://togithub.com/googleapis/java-bigtable/issues/1833)) ([cb160af](https://togithub.com/googleapis/java-bigtable/commit/cb160af8e66ec6693ed0d3286c654a93094b68a3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

@Sita04 Sita04

Labels
api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutianf @igorbernstein2 @Sita04