Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change stream retention to create and update table #1823

Merged
merged 6 commits into from
Jul 5, 2023
Merged

feat: change stream retention to create and update table #1823

merged 6 commits into from
Jul 5, 2023

Conversation

tonytanger
Copy link
Contributor

Follow up to #1821 adding update table support.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@tonytanger tonytanger requested a review from a team as a code owner June 28, 2023 20:36
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 28, 2023
feat: add change stream retention to create table
a28c5f9 
Change-Id: I6eec06f3e3178143150490aa5fd97b83b1878cd2
Tony Tang added 3 commits June 29, 2023 12:56
Remove creating change stream enabled table in IT because we can't de…
211f4f7 
…lete change stream enabled table

Change-Id: Ia2f92ccae3a2582da771b68a26adc1ab5f9d516e
feat: add update table with change stream retention
765996e 
Change-Id: I485507dd224eb0a3a160f7e9b5c569e1ae13ed84
Disable change stream at end of IT so the table can be deleted
7a7e40d 
Change-Id: I9b64e208ba3bf47f39a7bac3e4a3eb851b2c9468
@tonytanger tonytanger changed the title feat: add update table with change stream retention feat: change stream retention to create and update table Jun 29, 2023
Add change stream retention to create table IT
39666df 
Change-Id: I8076da5631aa4dc4f97bba88c8f799303e81a65f
mutianf
mutianf reviewed Jul 5, 2023
View reviewed changes
...oud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CreateTableRequest.java
@@ -76,6 +78,22 @@ public CreateTableRequest addSplit(ByteString key) {
return this;
}

/** Add change stream retention period between 1 day and 7 days */
public CreateTableRequest addChangeStreamRetention(Duration retention) {
Preconditions.checkNotNull(retention);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add precondition to check retention is between 1 and 7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what the philosophy is. Checking here would allow us to fail faster but if we widen the retention period then we have to change on the client side as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://google.aip.dev/client-libraries/4223, I think we should rely on the server side validation.

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner July 5, 2023 19:30
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2023
@mutianf mutianf merged commit 05fca58 into googleapis:main Jul 5, 2023
@release-please release-please bot mentioned this pull request Jul 5, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 17, 2023
@release-please
chore(main): release 2.25.0 (#1828)
e9b4034 
🤖 I have created a release *beep* *boop*
---


## [2.25.0](https://togithub.com/googleapis/java-bigtable/compare/v2.24.1...v2.25.0) (2023-07-14)


### Features

* Change stream retention to create and update table ([#1823](https://togithub.com/googleapis/java-bigtable/issues/1823)) ([05fca58](https://togithub.com/googleapis/java-bigtable/commit/05fca581d4225769cc581e26e679e6bca105055b))


### Bug Fixes

* Fix batch mutation limit ([#1808](https://togithub.com/googleapis/java-bigtable/issues/1808)) ([ed24d4f](https://togithub.com/googleapis/java-bigtable/commit/ed24d4fdc67c6d0af66ea055ba1ad7f7c037a361))
* Update default sample row key attempt timeout to 5 min ([#1827](https://togithub.com/googleapis/java-bigtable/issues/1827)) ([2f363ef](https://togithub.com/googleapis/java-bigtable/commit/2f363ef3636c2810c322bb5978cc586f8aec2ef2))


### Documentation

* Fix formatting for reversed order field example ([#1836](https://togithub.com/googleapis/java-bigtable/issues/1836)) ([10a0426](https://togithub.com/googleapis/java-bigtable/commit/10a0426f580b86b26541b95a778bb8b7f6562383))
* Increase the maximum retention period for a Cloud Bigtable backup from 30 days to 90 days ([#1826](https://togithub.com/googleapis/java-bigtable/issues/1826)) ([159fe38](https://togithub.com/googleapis/java-bigtable/commit/159fe3857735c9061672fc951388215edb0a324c))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.22.0 ([#1838](https://togithub.com/googleapis/java-bigtable/issues/1838)) ([fba2c49](https://togithub.com/googleapis/java-bigtable/commit/fba2c49e9e71209289497f53868aa561c0fba7a3))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 ([#1833](https://togithub.com/googleapis/java-bigtable/issues/1833)) ([cb160af](https://togithub.com/googleapis/java-bigtable/commit/cb160af8e66ec6693ed0d3286c654a93094b68a3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 left review comments

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonytanger @mutianf @kolea2 @yoshi-kokoro