-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track the latency a request is queued on the grpc channel #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: bigtable
Issues related to the googleapis/java-bigtable API.
labels
Jan 25, 2023
...e/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableGrpcStreamTracer.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java
Outdated
Show resolved
Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java
Outdated
Show resolved
Hide resolved
...d-bigtable-stats/src/test/java/com/google/cloud/bigtable/stats/StatsRecorderWrapperTest.java
Outdated
Show resolved
Hide resolved
...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracerStreamingCallable.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: m
Pull request size is medium.
labels
Apr 17, 2023
igorbernstein2
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after nit
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
mutianf
added
automerge
Merge the pull request once unit tests and other checks pass.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Apr 18, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 18, 2023
mutianf
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 18, 2023
igorbernstein2
approved these changes
Apr 19, 2023
mutianf
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 19, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 19, 2023
mutianf
added
automerge
Merge the pull request once unit tests and other checks pass.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Apr 19, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 19, 2023
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 19, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
🤖 I have created a release *beep* *boop* --- ## [2.21.0](https://togithub.com/googleapis/java-bigtable/compare/v2.20.4...v2.21.0) (2023-04-27) ### Features * Track the latency a request is queued on the grpc channel ([#1604](https://togithub.com/googleapis/java-bigtable/issues/1604)) ([bf3e7dd](https://togithub.com/googleapis/java-bigtable/commit/bf3e7dd58170bd058cedba8eea69b8c412ae68d3)) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.17.0 ([#1722](https://togithub.com/googleapis/java-bigtable/issues/1722)) ([c6f7767](https://togithub.com/googleapis/java-bigtable/commit/c6f776730bd1d78489be69d09744782e8b46c9b0)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.8.0 ([#1720](https://togithub.com/googleapis/java-bigtable/issues/1720)) ([aa230b5](https://togithub.com/googleapis/java-bigtable/commit/aa230b5be4e282ccaa506d360ce95fdbe58ed4bb)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/java-bigtable API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all operations, it tracks the latency of the request getting queued on a grpc channel. For batch operations, it's the aggregated value of grpc channel queued latency and batcher flow control latencies.