feat: split emulator into core without deps and a higher level wrapper with grpc helpers #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
…er with grpc helpers Currently the emulator exists in a single artifact with optional deps. The reason for this is that bigtable-hbase needs the emulator w/o grpc. However this is causing issues in graalvm packaging in googleapis#1234. This PR makes this easier to manage: a -core artifact without dependencies that just wraps the golang binary that bigtable-hbase can use and a wrapper that has a hard dep on grpc & gax. This is technically a breaking change but the emulator artifact is pre-GA an is marked with BetaApi
igorbernstein2
force-pushed
the
split-emulator
branch
from
9f93918 to
c3e99cd
Compare
mpeddada1
approved these changes
May 26, 2022
There was a problem hiding this comment.
Thanks @igorbernstein2! I have tried this locally with native image testing and it works great! Looks great from my end.
igorbernstein2
changed the title
kolea2
approved these changes
May 26, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
suggested changes
May 26, 2022
There was a problem hiding this comment.
Please add this new module to the repo metadata: https://github.com/googleapis/java-bigtable/blob/main/.repo-metadata.json#L15
igorbernstein2
force-pushed
the
split-emulator
branch
from
33f8419 to
c10f36c
Compare
igorbernstein2
added
the
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
approved these changes
May 26, 2022
kolea2
suggested changes
May 26, 2022
igorbernstein2
force-pushed
the
split-emulator
branch
from
8cabf8f to
097b6ea
Compare
kolea2
approved these changes
May 26, 2022
igorbernstein2
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 26, 2022
This was introduced in #1264
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 31, 2022
🤖 I have created a release *beep* *boop* --- ## [2.8.0](v2.7.0...v2.8.0) (2022-05-27) ### Features * split emulator into core without deps and a higher level wrapper with grpc helpers ([#1264](#1264)) ([6fdc2c1](6fdc2c1)) ### Bug Fixes * **java:** enable skipped tests for Native Image testing ([#1234](#1234)) ([560a501](560a501)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the emulator exists in a single artifact with optional deps. The reason for this is that bigtable-hbase needs the emulator w/o grpc. However this is causing issues in graalvm packaging in #1234. This PR makes this easier to manage: a -core artifact without dependencies that just wraps the golang binary that bigtable-hbase can use and a wrapper that has a hard dep on grpc & gax.
This is technically a breaking change but the emulator artifact is pre-GA an is marked with BetaApi
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.