Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sample): Add sample for native image support in Bigtable #1165

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Feb 8, 2022

This PR copies over the sample for native image support in Bigtable from the old native image support repo.

Some things to note:

  1. This PR slightly modifies the sample code to be more test-friendly.
  2. It also adds an integration test that can be run as a native image.

Calling mvn package -Pnative in the native-image-sample directory builds the native image for the application and calling mvn test -Pnative runs the test as a native image.

For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration

@mpeddada1 mpeddada1 requested review from a team as code owners February 8, 2022 22:52
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

@snippet-bot
Copy link

snippet-bot bot commented Feb 8, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Feb 8, 2022
@Neenu1995 Neenu1995 requested a review from kolea2 February 8, 2022 22:54
@mpeddada1
Copy link
Contributor Author

The failing GraalVM test is due to no tests being run with the native profile in the emulator module. This is a known issue with the native-maven-plugin, which fails with the following message: Execution test-native of goal org.graalvm.buildtools:native-maven-plugin:0.9.9:test failed: Test configuration file wasn't found.

@mpeddada1
Copy link
Contributor Author

Thanks for the review @lesv!

@mpeddada1 mpeddada1 merged commit 143aaee into main Feb 14, 2022
@mpeddada1 mpeddada1 deleted the add-native-samples branch February 14, 2022 15:39
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
…apis#1165)

* docs(sample): add sample for native image support

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add setup instructions to readme

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants