Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: @Nullable annotations on builder methods #3222

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Fix: @Nullable annotations on builder methods #3222

merged 5 commits into from
Apr 24, 2024

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Mar 29, 2024 •
edited
Loading

This fixes errors in the latest versions of AutoValue

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionSettings.java:225: error: [AutoValueBuilderSetterNullable] Setter methods always return the Builder so @Nullable is not appropriate
    public abstract Builder setUseReadAPI(Boolean useReadAPI);
                            ^

Fixes #3221 ☕️

@cushon
Fix @nullable annotations on builder methods
6b730fd 
This fixes errors in the latest versions of AutoValue

```
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionSettings.java:225: error: [AutoValueBuilderSetterNullable] Setter methods always return the Builder so @nullable is not appropriate
    public abstract Builder setUseReadAPI(Boolean useReadAPI);
                            ^
```
@cushon cushon requested a review from a team as a code owner March 29, 2024 22:45
@cushon cushon requested a review from shollyman March 29, 2024 22:45
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Mar 29, 2024
@PhongChuong PhongChuong changed the title Fix @Nullable annotations on builder methods Fix: @Nullable annotations on builder methods Apr 17, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Apr 17, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@cushon cushon requested a review from a team as a code owner April 17, 2024 18:02
@PhongChuong PhongChuong self-requested a review April 22, 2024 18:31
PhongChuong
PhongChuong requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing and cleaning up the code space. I've left some comments, please take a look.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionSettings.java Outdated Show resolved Hide resolved
...loud-bigquery/src/main/java/com/google/cloud/bigquery/ReadClientConnectionConfiguration.java Show resolved Hide resolved
...loud-bigquery/src/main/java/com/google/cloud/bigquery/ReadClientConnectionConfiguration.java Show resolved Hide resolved
...loud-bigquery/src/main/java/com/google/cloud/bigquery/ReadClientConnectionConfiguration.java Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 22, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Apr 23, 2024
@PhongChuong
Copy link
Contributor

/gcbrun

@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 24, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 24, 2024
@PhongChuong
Copy link
Contributor

/gcbrun

@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2024
@PhongChuong
Copy link
Contributor

@cushon, thank you for your contributions.

@PhongChuong PhongChuong merged commit 0c5eed1 into googleapis:main Apr 24, 2024
18 checks passed
@cushon
Copy link
Contributor Author

cushon commented Apr 24, 2024

@cushon, thank you for your contributions.

Thanks for the review!

@release-please release-please bot mentioned this pull request Apr 29, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 29, 2024
@release-please
chore(main): release 2.39.1 (#3275)
c2e3283 
🤖 I have created a release *beep* *boop*
---


## [2.39.1](https://togithub.com/googleapis/java-bigquery/compare/v2.39.0...v2.39.1) (2024-04-29)


### Bug Fixes

* @nullable annotations on builder methods ([#3222](https://togithub.com/googleapis/java-bigquery/issues/3222)) ([0c5eed1](https://togithub.com/googleapis/java-bigquery/commit/0c5eed1a18409f120a1243bd5da1db2aa4f9c206))


### Dependencies

* Update actions/checkout action ([#3267](https://togithub.com/googleapis/java-bigquery/issues/3267)) ([c297ed2](https://togithub.com/googleapis/java-bigquery/commit/c297ed2c77e36257451b5c12e4988f3293cdbb88))
* Update actions/upload-artifact action to v4.3.3 ([#3258](https://togithub.com/googleapis/java-bigquery/issues/3258)) ([5215235](https://togithub.com/googleapis/java-bigquery/commit/52152350a2a6218b51ebf3d7dd6beb2699064a3c))
* Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.44.0 ([#3270](https://togithub.com/googleapis/java-bigquery/issues/3270)) ([ee09ab6](https://togithub.com/googleapis/java-bigquery/commit/ee09ab68ea2be824aaf4e3d08b67e3bfbab2977f))
* Update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v3.5.0 ([e7c6201](https://togithub.com/googleapis/java-bigquery/commit/e7c620119321b673c19b99adb79247cd3c52cd67))
* Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.48.0 ([#3271](https://togithub.com/googleapis/java-bigquery/issues/3271)) ([3b6e0d5](https://togithub.com/googleapis/java-bigquery/commit/3b6e0d5e3d26b8e2de412aa926a638d72562d4a0))
* Update github/codeql-action action to v2.25.2 ([#3260](https://togithub.com/googleapis/java-bigquery/issues/3260)) ([3302dc4](https://togithub.com/googleapis/java-bigquery/commit/3302dc46e3e2c6a173798ef7f1642d3d4cb20332))
* Update github/codeql-action action to v2.25.3 ([#3268](https://togithub.com/googleapis/java-bigquery/issues/3268)) ([1cf2377](https://togithub.com/googleapis/java-bigquery/commit/1cf237702e16952029741c306aa57cb3558a663f))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced May 7, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhongChuong PhongChuong PhongChuong approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation error with the latest versions of AutoValue
3 participants
@cushon @PhongChuong @yoshi-kokoro