NDB: No longer excluding __repr__ and abstract methods in coverage.
#6694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crwilcox
approved these changes
Dec 3, 2018
|
We can remove these from NDB. The generated libs had theses excluded. If removing them in this case makes sense I am happy to cover them here. |
chrisrossi
pushed a commit
to chrisrossi/google-cloud-python
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added in #6642 but I think they should be there:
__repr__for the original source__repr__implementations are verboseraise NotImplementedErrorI also think that
fail_under = 100should be removed from[report]. It causes thepytest ...invocation to fail, and sosession.notify("cover")never gets triggered and the actual coverage report of missing lines is no longer printed.