Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SPM methods check that 'self._consumer' is not None before use. #5758

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Ensure SPM methods check that 'self._consumer' is not None before use. #5758

merged 1 commit into from
Aug 6, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 6, 2018

Closes #5751.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Aug 6, 2018
@tseaver tseaver requested a review from theacodes August 6, 2018 18:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2018
mcdonc
mcdonc approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@mcdonc mcdonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver force-pushed the 5751-pubsub-streamingpullmanager-check_consumer_none branch from e43e4d1 to 4dd8778 Compare August 6, 2018 18:56
@tseaver
Copy link
Contributor Author

tseaver commented Aug 6, 2018

I've rebased to fix CI.

@tseaver tseaver merged commit 76de334 into master Aug 6, 2018
@tseaver tseaver deleted the 5751-pubsub-streamingpullmanager-check_consumer_none branch August 6, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonc mcdonc mcdonc approved these changes

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @mcdonc @googlebot