Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remap new Gax conflict error code #3443

Merged
merged 3 commits into from
Jun 7, 2017
Merged

Remap new Gax conflict error code #3443

merged 3 commits into from
Jun 7, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 19, 2017

Closes #3175.

Note: this is a pubsub-only fix for the ALREADY_EXISTS error code change.

Note: also updates core._testing to ease generation of errors with that code.

@tseaver tseaver added api: pubsub Issues related to the Pub/Sub API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 19, 2017
@tseaver tseaver requested review from lukesneeringer and dhermes May 19, 2017 19:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2017
@tseaver tseaver changed the title 3175 pubsub new conflict error code Remap new Gax conflict error code May 19, 2017
@tseaver tseaver added the gax label May 19, 2017
dhermes
dhermes reviewed May 19, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kir-titievsky Can you (or someone on your team) confirm that the error has changed from FAILED_PRECONDITION to ALREADY_EXISTS?

@tseaver We should hold off on merging until we can confirm?

@tseaver
Copy link
Contributor Author

tseaver commented May 19, 2017

@dhermes The new system test assertions fails before applying the change, and succeeds afterward. We didn't have system tests which provoked conflicts before.

The only real question is whether the back-end still returns FAILED_PRECONDITION for some errors which we are still supposed to map to Conflict.

@tseaver tseaver mentioned this pull request Jun 5, 2017
Closed
@dhermes
Copy link
Contributor

dhermes commented Jun 6, 2017

@tseaver Are you blocked on this?

@kir-titievsky Can you (or someone on your team) confirm that the error has changed from FAILED_PRECONDITION to ALREADY_EXISTS?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 6, 2017

@dhermes I haven't seen an approval.

@dhermes
Copy link
Contributor

dhermes commented Jun 6, 2017

@tseaver I want to see if we can get some kind of "official" clarification before approving, but let's limit that to 24 hours from here? Didn't you say the other PR obsoletes this one though?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 7, 2017

@dhermes #3444 would "start fixin' to commence to get ready" to obsolete this PR. :) It only does the initial move of the exception remapper from bigtable to core. There would be further work to update how gRPC exception is handled throughout the various gRPC-enabled API libraries.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 7, 2017

Following up, I would say we should go ahead and merge this one. The new system test (which passes with the new ALREADY_EXISTS code in place) will still be a useful guard for the future work set up by #3444.

@dhermes
Copy link
Contributor

dhermes commented Jun 7, 2017

Yeah go ahead and merge (I got mixed up on which PR was "24 hr gated")

@tseaver tseaver merged commit 8dacdb9 into googleapis:master Jun 7, 2017
@tseaver tseaver deleted the 3175-pubsub-new_conflict_error_code branch June 7, 2017 20:02
This was referenced Jun 26, 2017
Merged
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tseaver @landrito
Remap new Gax conflict error code (googleapis#3443)
40e7cf4 
* Add testing support for 'ALREADY_EXISTS' gRPC error code.

* Cover both possible gRPC conflict error codes.

Closes googleapis#3175.

* Exercise conflict-on-create in systests for topic/sub/snap.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Remap new Gax conflict error code (googleapis#3443)
4571b52 
* Add testing support for 'ALREADY_EXISTS' gRPC error code.

* Cover both possible gRPC conflict error codes.

Closes googleapis#3175.

* Exercise conflict-on-create in systests for topic/sub/snap.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Remap new Gax conflict error code (googleapis#3443)
33b007c 
* Add testing support for 'ALREADY_EXISTS' gRPC error code.

* Cover both possible gRPC conflict error codes.

Closes googleapis#3175.

* Exercise conflict-on-create in systests for topic/sub/snap.
parthea pushed a commit that referenced this pull request Jun 4, 2023
@arithmetic1728 @beccasaurus
@gguuss @kurtisvg @dpebot @dmahugh @nnegrey @leahecole @renovate-bot @busunkim96
chore: move samples from python-docs-sample to here (#29)
8d9e265 
* Data Labeling Beta samples [(#2096)](GoogleCloudPlatform/python-docs-samples#2096)

* add files

* upate create_annotation_spec_set and test

* add requirements.txt

* update create_instruction and test

* update import data and test

* add label image and test

* add label_text test

* add label_video_test

* add manage dataset and tests

* flake

* fix

* add README

* Adds updates including compute [(#2436)](GoogleCloudPlatform/python-docs-samples#2436)

* Adds updates including compute

* Python 2 compat pytest

* Fixing weird \r\n issue from GH merge

* Put asset tests back in

* Re-add pod operator test

* Hack parameter for k8s pod operator

* Update datalabeling samples to hit test endpoint. [(#2641)](GoogleCloudPlatform/python-docs-samples#2641)

* Auto-update dependencies. [(#2005)](GoogleCloudPlatform/python-docs-samples#2005)

* Auto-update dependencies.

* Revert update of appengine/flexible/datastore.

* revert update of appengine/flexible/scipy

* revert update of bigquery/bqml

* revert update of bigquery/cloud-client

* revert update of bigquery/datalab-migration

* revert update of bigtable/quickstart

* revert update of compute/api

* revert update of container_registry/container_analysis

* revert update of dataflow/run_template

* revert update of datastore/cloud-ndb

* revert update of dialogflow/cloud-client

* revert update of dlp

* revert update of functions/imagemagick

* revert update of functions/ocr/app

* revert update of healthcare/api-client/fhir

* revert update of iam/api-client

* revert update of iot/api-client/gcs_file_to_device

* revert update of iot/api-client/mqtt_example

* revert update of language/automl

* revert update of run/image-processing

* revert update of vision/automl

* revert update testing/requirements.txt

* revert update of vision/cloud-client/detect

* revert update of vision/cloud-client/product_search

* revert update of jobs/v2/api_client

* revert update of jobs/v3/api_client

* revert update of opencensus

* revert update of translate/cloud-client

* revert update to speech/cloud-client

Co-authored-by: Kurtis Van Gent <[email protected]>
Co-authored-by: Doug Mahugh <[email protected]>

* Update datalabeling to match lint. [(#2642)](GoogleCloudPlatform/python-docs-samples#2642)

* datalabeling: ensure all tests use test endpoint [(#2918)](GoogleCloudPlatform/python-docs-samples#2918)

* datalabeling: ensure all tests use test endpoint

* requires an input csv for text input, slight print statement cleanup

Co-authored-by: Leah E. Cole <[email protected]>

* chore(deps): update dependency google-cloud-datalabeling to v0.4.0 [(#3081)](GoogleCloudPlatform/python-docs-samples#3081)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [google-cloud-datalabeling](https://togithub.com/googleapis/python-datalabeling) | minor | `==0.3.0` -> `==0.4.0` |

---

### Release Notes

<details>
<summary>googleapis/python-datalabeling</summary>

### [`v0.4.0`](https://togithub.com/googleapis/python-datalabeling/blob/master/CHANGELOG.md#&#8203;040-httpswwwgithubcomgoogleapispython-datalabelingcomparev030v040-2020-01-31)

[Compare Source](https://togithub.com/googleapis/python-datalabeling/compare/v0.3.0...v0.4.0)

##### Features

-   **datalabeling:** undeprecate resource name helper methods (via synth) ([#&#8203;10039](https://www.github.com/googleapis/python-datalabeling/issues/10039)) ([88f8090](https://www.github.com/googleapis/python-datalabeling/commit/88f809008ee6a709c02c78b1d93af779fab19adb))

##### Bug Fixes

-   **datalabeling:** deprecate resource name helper methods (via synth) ([#&#8203;9832](https://www.github.com/googleapis/python-datalabeling/issues/9832)) ([e5f9021](https://www.github.com/googleapis/python-datalabeling/commit/e5f902154ebe7fcb139aa405babfe9993fd51319))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

* Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <[email protected]>

* testing: mark some tests as flaky [(#3288)](GoogleCloudPlatform/python-docs-samples#3288)

fixes #3138

* [datalabeling] testing: wrap rpcs with backoff [(#3443)](GoogleCloudPlatform/python-docs-samples#3443)

* wrap all the rpcs with backoff
* add a shared testing lib
* remove flaky

* [datalabeling] fix: clean up old datasets before the test [(#3707)](GoogleCloudPlatform/python-docs-samples#3707)

fixes #3710 
fixes #3711

* [datalabeling] testing: retry upon ServerError [(#3762)](GoogleCloudPlatform/python-docs-samples#3762)

fixes #3760

* Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleCloudPlatform/python-docs-samples#4022)

* chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279)

* chore(deps): update dependency pytest to v5.4.3

* specify pytest for python 2 in appengine

Co-authored-by: Leah Cole <[email protected]>

* Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390)

* chore: update templates

* chore: fix docs error

* chore: skip unavailable samples

* chore: use staging endpoint for labeling tests

Co-authored-by: Rebecca Taylor <[email protected]>
Co-authored-by: Gus Class <[email protected]>
Co-authored-by: Kurtis Van Gent <[email protected]>
Co-authored-by: DPEBot <[email protected]>
Co-authored-by: Doug Mahugh <[email protected]>
Co-authored-by: Noah Negrey <[email protected]>
Co-authored-by: Leah E. Cole <[email protected]>
Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Takashi Matsuo <[email protected]>
Co-authored-by: Leah Cole <[email protected]>
Co-authored-by: Bu Sun Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PubSub topic.create method should raise a Conflict error instead of RetryError/GaxError when topic exists
3 participants
@tseaver @dhermes @googlebot