Conform to expected wire format for struct query parameters. #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
api: bigquery
googlebot
added
the
cla: yes
tswast
reviewed
Dec 20, 2016
| @@ -1188,13 +1196,17 @@ def test_from_api_repr_w_name(self): | |||
| def test_from_api_repr_wo_name(self): | |||
| RESOURCE = { | |||
| 'parameterType': { | |||
| 'type': 'STRUTCT', | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
reviewed
Dec 21, 2016
| @@ -554,10 +555,12 @@ def from_api_repr(cls, resource): | |||
| instance = cls(name) | |||
| types = instance.struct_types | |||
| for item in resource['parameterType']['structTypes']: | |||
| types[item['name']] = item['type'] | |||
| types[item['name']] = item['type']['type'] | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -568,18 +571,19 @@ def to_api_repr(self): | |||
| :returns: JSON mapping | |||
| """ | |||
| types = [ | |||
| {'name': key, 'type': value} | |||
| {'name': key, 'type': {'type': value}} | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
approved these changes
Dec 21, 2016
| @@ -554,10 +555,12 @@ def from_api_repr(cls, resource): | |||
| instance = cls(name) | |||
| types = instance.struct_types | |||
| for item in resource['parameterType']['structTypes']: | |||
| types[item['name']] = item['type'] | |||
| types[item['name']] = item['type']['type'] | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -554,10 +555,12 @@ def from_api_repr(cls, resource): | |||
| instance = cls(name) | |||
| types = instance.struct_types | |||
| for item in resource['parameterType']['structTypes']: | |||
| types[item['name']] = item['type'] | |||
| types[item['name']] = item['type']['type'] | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…query-parm Conform to expected wire format for struct query parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2887.
/cc @tswast