Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Makefile to only use gRPC when needed. #1354

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 7, 2016

NOTE: Has #1353 as diffbase.

Also re-running the generate rule and updating the files that don't need gRPC.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Jan 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2016
@dhermes dhermes added the build label Jan 7, 2016
@dhermes dhermes force-pushed the only-use-grpc-when-needed branch 2 times, most recently from 141b08f to 8dc8981 Compare January 14, 2016 23:22
Also re-running the generate rule and updating the
files that don't need gRPC.
@dhermes dhermes force-pushed the only-use-grpc-when-needed branch from 8dc8981 to 2db43d3 Compare January 15, 2016 02:27
@dhermes
Copy link
Contributor Author

dhermes commented Jan 15, 2016

@tseaver PTAL. Rebased after merging #1353.

@tseaver
Copy link
Contributor

tseaver commented Jan 15, 2016

LGTM

dhermes added a commit that referenced this pull request Jan 15, 2016
Updating Makefile to only use gRPC when needed.
@dhermes dhermes merged commit 3f18953 into googleapis:master Jan 15, 2016
@dhermes dhermes deleted the only-use-grpc-when-needed branch January 15, 2016 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants