Avoiding grpcio==1.6.0 in deps.
#4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
dhermes
requested review from
duggelz,
liyanhui1228,
lukesneeringer,
tseaver and
waprin
as code owners
googlebot
added
the
cla: yes
dhermes
removed request for
lukesneeringer,
tseaver,
duggelz,
waprin and
liyanhui1228
tseaver
approved these changes
Oct 2, 2017
|
I am going to merge right now since this is just for RTD. |
|
Fingers crossed: https://readthedocs.org/projects/google-cloud-python/builds/6064325/ |
Closed
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
This is due to `google-gax` doing the same, which has broken RTD builds: https://readthedocs.org/projects/google-cloud-python/builds/6063446/ The motivation for avoiding `grpcio==1.6.0` is: grpc/grpc#12455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to
google-gaxdoing the same, which has brokenRTD builds:
https://readthedocs.org/projects/google-cloud-python/builds/6063446/
The motivation for avoiding
grpcio==1.6.0is:grpc/grpc#12455
@lukesneeringer I'm unclear, but it's possible that
googleapis-common-protoswill need to have the strict upper bound set as well (it currently has>= 1.0.0).