Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision support ImageContext throughout all detection types. #3132

Closed
daspecster opened this issue Mar 10, 2017 · 3 comments
Closed

Vision support ImageContext throughout all detection types. #3132

daspecster opened this issue Mar 10, 2017 · 3 comments
Assignees
Labels
api: vision Issues related to the Cloud Vision API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@daspecster
Copy link
Contributor

I think the reason this wasn't supported before was because it wasn't supported on all the detection types.

Right now it's only really in Crop Hints.

If someone can confirm that this is supported on everything else, I can start adding it.

@daspecster daspecster added the api: vision Issues related to the Cloud Vision API. label Mar 10, 2017
@lukesneeringer
Copy link
Contributor

Huh?

@daspecster
Copy link
Contributor Author

This might explain a bit better.

I've abstracted the usage away from the user and just allowed them to pass in values that coincide with the API they're using, but my question is maybe I should expose that for all the detection types if it's used by all the detection types? But I don't know if they all use it or not?

@lukesneeringer
Copy link
Contributor

All this code is gone. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

2 participants