Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecretManagerServiceClient: missing staticmethod decorators on two methods #12255

Closed
Salvo-kun opened this issue Feb 2, 2024 · 1 comment
Closed

SecretManagerServiceClient: missing staticmethod decorators on two methods #12255

Salvo-kun opened this issue Feb 2, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Salvo-kun
Copy link

The methods are:

  • _get_client_cert_source
  • _get_api_endpoint

It is mainly a matter of consistency but also to avoid eventual accesses through self.
@Salvo-kun Salvo-kun mentioned this issue Feb 2, 2024
Closed
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 2, 2024
@parthea parthea mentioned this issue Feb 2, 2024
Merged
@parthea
Copy link
Contributor

parthea commented Feb 3, 2024

Thanks for reporting this issue. It was included in googleapis/gapic-generator-python#1923 and the fix was added to this repository via #12266.

@parthea parthea closed this as completed Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@parthea @Salvo-kun