feat: introduce StorageControl #7245
Conversation
|
Here is the summary of changes. You are about to add 10 region tags.
This comment is generated by snippet-bot.
|
| */ | ||
|
|
||
| return [ | ||
| 'interfaces' => [], |
There was a problem hiding this comment.
By it being empty does this mean REST is not available?
There was a problem hiding this comment.
Yes. This is where the http annotations would go. It being empty means someone trying to run this with the rest transport would get a PHP fatal error.
There was a problem hiding this comment.
This is something we should be able to fix without too much trouble (see googleapis/gapic-generator-php#705)
There was a problem hiding this comment.
I do not see a major issue into having an error thrown in case REST is specified. The library user does get an actionable insight in that case, so I think we could merge this PR and iterate with gapic-generators later.
There was a problem hiding this comment.
I agree! I was just hoping to release with it because it's a better experience. If we don't get it in by tomorrow, I will still merge this for the release.
bshaffer
added
do not merge
|
Adding "Do Not Merge" label because I'd like to get in googleapis/gapic-generator-php#705 before we release this (although it isn't a blocker) |
| 'defaultScopes' => self::$serviceScopes, | ||
| ], | ||
| 'transportConfig' => [ | ||
| 'rest' => [ |
There was a problem hiding this comment.
This mentions rest though.
There was a problem hiding this comment.
You're right! Thank you for pointing this out. We should be able to remove this in googleapis/gapic-generator-php#707
bshaffer
removed
the
do not merge
No description provided.