Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce SecurityCenterManagement #6852

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat: Introduce SecurityCenterManagement #6852

merged 2 commits into from
Dec 8, 2023

Conversation

ajupazhamayil
Copy link
Contributor

PiperOrigin-RevId: 588171027

b/315024355

@ajupazhamayil ajupazhamayil requested review from a team as code owners December 7, 2023 12:27
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Dec 7, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 20 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

yash30201
yash30201 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@yash30201 yash30201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on prod, it's working.
LGTM

The docs aren't yet published by the tech writing team and that's why links return 404. But all other languages are going ahead with the release as the tech writing team is at final stage and will publish them soon.

bshaffer
bshaffer requested changes Dec 7, 2023
View reviewed changes
SecurityCenterManagement/README.md Outdated Show resolved Hide resolved
SecurityCenterManagement/README.md Show resolved Hide resolved
@yash30201
Copy link
Contributor

Adding a do not merge label as component repository is not there as of now
https://github.com/googleapis/google-cloud-php-securitycentermanagement

@yash30201 yash30201 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 8, 2023
@bshaffer bshaffer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 8, 2023
@bshaffer bshaffer merged commit 5d91fb2 into main Dec 8, 2023
24 checks passed
@bshaffer bshaffer deleted the securitycentermanagement branch December 8, 2023 22:22
@release-please release-please bot mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand left review comments

@bshaffer bshaffer bshaffer approved these changes

@yash30201 yash30201 yash30201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajupazhamayil @yash30201 @bshaffer @vishwarajanand