Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BigQuery): Enable session in load job #6576

Merged
merged 4 commits into from
Sep 7, 2023
Merged

feat(BigQuery): Enable session in load job #6576

merged 4 commits into from
Sep 7, 2023

Conversation

ajupazhamayil
Copy link
Contributor

@ajupazhamayil ajupazhamayil commented Aug 21, 2023 •
edited by vishwarajanand
Loading

@ajupazhamayil ajupazhamayil requested review from a team as code owners August 21, 2023 19:53
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Aug 21, 2023
@ajupazhamayil ajupazhamayil marked this pull request as draft August 21, 2023 19:54
@ajupazhamayil ajupazhamayil force-pushed the bigquery_load_session branch from 1a5fdab to ea1327e Compare August 21, 2023 20:03
@ajupazhamayil ajupazhamayil force-pushed the bigquery_load_session branch from 622047c to 271054a Compare August 28, 2023 21:07
@ajupazhamayil ajupazhamayil marked this pull request as ready for review August 29, 2023 10:22
vishwarajanand
vishwarajanand requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs chnages to test and closure on default values

@ajupazhamayil
Copy link
Contributor Author

Thank you for the review, I have replied to your comments @vishwarajanand, Please have a look.

yash30201
yash30201 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@yash30201 yash30201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a single nit.

vishwarajanand
vishwarajanand approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishwarajanand vishwarajanand merged commit c27f058 into main Sep 7, 2023
@vishwarajanand vishwarajanand deleted the bigquery_load_session branch September 7, 2023 16:47
@release-please release-please bot mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

@yash30201 yash30201 yash30201 approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajupazhamayil @vishwarajanand @yash30201