feat(BigQuery): Add JSON datatype #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
ajupazhamayil
force-pushed
the
jsonBigQuery
branch
7 times, most recently
from
7d0931b to
e33ee4d
Compare
ajupazhamayil
force-pushed
the
jsonBigQuery
branch
from
e33ee4d to
b186bdb
Compare
vishwarajanand
requested changes
Jul 11, 2023
ajupazhamayil
force-pushed
the
jsonBigQuery
branch
3 times, most recently
from
c7585b1 to
783e599
Compare
|
@vishwarajanand Made the required changes, Please have a look! Thank you! |
ajupazhamayil
force-pushed
the
jsonBigQuery
branch
from
58e23e0 to
15100de
Compare
There was a problem hiding this comment.
Per our internal discussions, we want the user to parse the JSON and the library will only provide a JSON string.
Some considerations (not all) are PHP's json_encode or json_decode doesn't actually cover all the possible range of JSON values (such as float, decimals) as supported by backend, nested JSON depth also might increase in future, as opposed to max 512 allowed in PHP.
vishwarajanand
requested changes
Jul 31, 2023
ajupazhamayil
commented
Aug 2, 2023
vishwarajanand
requested changes
Aug 4, 2023
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add JSON datatype in BigQuery. Also resolves #6413 #5151
go/php-bigquery-json-datatype