-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Spanner): default creator role is empty str #5941
Merged
bshaffer
merged 5 commits into
googleapis:main
from
vishwarajanand:spanner_creator_role_fix_default
Mar 17, 2023
Merged
fix(Spanner): default creator role is empty str #5941
bshaffer
merged 5 commits into
googleapis:main
from
vishwarajanand:spanner_creator_role_fix_default
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajupazhamayil
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the discussion, no defaults mentioned in the proto file here https://github.com/googleapis/googleapis/blob/master/google/spanner/v1/spanner.proto#L362. Seems like the string type in proto automatically assumes empty string as defaults in the gapic files here
private $creator_role = ''; |
bshaffer
reviewed
Mar 17, 2023
bshaffer
reviewed
Mar 17, 2023
bshaffer
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to migrate default creator role to empty string instead of a null string to avoid failures in
System\SessionTest::testCacheSessionPool
wherecreator_role
is null (not empty string) and emulator is rejecting it:google-cloud-php/Spanner/src/Session/CacheSessionPool.php
Line 695 in 06e3f61
This change will bring spanner's creator roles in line with other language libraries, such as Go and with autogenerated changes:
google-cloud-php/Spanner/src/V1/Session.php
Line 54 in fb87e51
Note: unfortunately, this will be a BC breaking change.