feat: [SqlAdmin] add new fields to DatabaseInstance message in the cloud_sql_resources.proto and cleanup proto descriptions
#5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
trusted-contributions-gcf
bot
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
kokoro-team
removed
the
kokoro:force-run
dwsupplee
approved these changes
Jan 26, 2022
dwsupplee
changed the title
DatabaseInstance message in the cloud_sql_resources.proto and cleanup proto descriptionsDatabaseInstance message in the cloud_sql_resources.proto and cleanup proto descriptions
bshaffer
changed the title
DatabaseInstance message in the cloud_sql_resources.proto and cleanup proto descriptionsDatabaseInstance message in the cloud_sql_resources.proto and cleanup proto descriptions
|
@dwsupplee let's keep the Component names in the PR titles - otherwise it's very difficult to keep things organized |
|
I have opened googleapis/synthtool#1341 to address the failures. |
I got into the habit of removing them prior to a merge to help keep the release notes clean - otherwise you see the package title in front of every commit we list. It is a bit noisy as you already know what package you're looking at in the notes. I'm fine with keeping it, but then it may be nice to have some tooling that knows to purge it out from the commit notes. |
|
Owl bot is regenerating pull request 5061... |
…esources.proto and cleanup proto descriptions PiperOrigin-RevId: 424175097 Source-Link: googleapis/googleapis@ce08228 Source-Link: googleapis/googleapis-gen@9c08882 Copy-Tag: eyJwIjoiU3FsQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6IjljMDg4ODI3NzMzNGMzNWYwNzFmMDcxZmY1MThiN2MxMzlkMmFlOTkifQ==
gcf-owl-bot
bot
force-pushed
the
owl-bot-f125e089-bf6e-4867-9e59-dabd84d236b8
branch
from
4bbaae6 to
55c80ee
Compare
trusted-contributions-gcf
bot
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
bshaffer
approved these changes
Jan 27, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 424175097
Source-Link: googleapis/googleapis@ce08228
Source-Link: https://github.com/googleapis/googleapis-gen/commit/9c0888277334c35f071f071ff518b7c139d2ae99
Copy-Tag: eyJwIjoiU3FsQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6IjljMDg4ODI3NzMzNGMzNWYwNzFmMDcxZmY1MThiN2MxMzlkMmFlOTkifQ==