Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Add support for archive storage class #2425

Closed
tritone opened this issue Oct 25, 2019 · 0 comments · Fixed by #2428
Closed

Storage: Add support for archive storage class #2425

tritone opened this issue Oct 25, 2019 · 0 comments · Fixed by #2428
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tritone
Copy link

tritone commented Oct 25, 2019

GCS is adding a storage class called "archive" to the existing options for object storage (coldline, standard, etc). Support for this should be added to this client library. This has already been implemented in the C++ client library and there is a PR in python; reference PR here

For this library, this will just require a documentation update since storage class is just passed as a string and there is not any enum or constant. Any comment mentioning other storage classes should be updated to also mention archive.

I found the following places where the docs should be updated:

Also, it might be good to update one or more of the tests of storage class to use ARCHIVE.

@dwsupplee dwsupplee added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants