Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Optimized to FeatureOnlineStore #4790

Merged
merged 4 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package google.cloud.aiplatform.v1beta1;

import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/cloud/aiplatform/v1beta1/service_networking.proto";
import "google/protobuf/timestamp.proto";

option csharp_namespace = "Google.Cloud.AIPlatform.V1Beta1";
Expand Down Expand Up @@ -60,12 +61,29 @@ message FeatureOnlineStore {
AutoScaling auto_scaling = 1 [(google.api.field_behavior) = REQUIRED];
}

// The dedicated serving endpoint for this FeatureOnlineStore.
// Optimized storage type to replace lightning
message Optimized {}

// The dedicated serving endpoint for this FeatureOnlineStore. Only need to
// set when you choose Optimized storage type or enable EmbeddingManagement.
// Will use public endpoint by default.
message DedicatedServingEndpoint {
// Output only. This field will be populated with the domain name to use for
// this FeatureOnlineStore
string public_endpoint_domain_name = 2
[(google.api.field_behavior) = OUTPUT_ONLY];

// Optional. Private service connect config.
// If
// [PrivateServiceConnectConfig.enable_private_service_connect][google.cloud.aiplatform.v1beta1.PrivateServiceConnectConfig.enable_private_service_connect]
// set to true, customers will use private service connection to send
// request. Otherwise, the connection will set to public endpoint.
PrivateServiceConnectConfig private_service_connect_config = 3
[(google.api.field_behavior) = OPTIONAL];

// Output only. The name of the service attachment resource. Populated if
// private service connect is enabled and after FeatureViewSync is created.
string service_attachment = 4 [(google.api.field_behavior) = OUTPUT_ONLY];
}

// Contains settings for embedding management.
Expand Down Expand Up @@ -101,6 +119,13 @@ message FeatureOnlineStore {
// to serve featureValues for all FeatureViews under this
// FeatureOnlineStore.
Bigtable bigtable = 8;

// Contains settings for the Optimized store that will be created
// to serve featureValues for all FeatureViews under this
// FeatureOnlineStore. When choose Optimized storage type, need to set
// [PrivateServiceConnectConfig.enable_private_service_connect][google.cloud.aiplatform.v1beta1.PrivateServiceConnectConfig.enable_private_service_connect]
// to use private endpoint. Otherwise will use public endpoint by default.
Optimized optimized = 12;
}

// Output only. Name of the FeatureOnlineStore. Format:
Expand Down
Loading