Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [vmwareengine] improve retry logic for streaming API calls #4960

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 18, 2024

  • Regenerate this pull request now.

build: update typescript generator version to 4.3.0

The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.

PiperOrigin-RevId: 599622271

Source-Link: googleapis/googleapis@6239c21

Source-Link: https://github.com/googleapis/googleapis-gen/commit/da13d8222d3ba33734501999864458640f1405ae
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZtd2FyZWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiZGExM2Q4MjIyZDNiYTMzNzM0NTAxOTk5ODY0NDU4NjQwZjE0MDVhZSJ9

BEGIN_NESTED_COMMIT
feat: [vmwareengine] Adding ManagementDnsZoneBinding, DnsBindPermission, DnsForwarding, ExternalAccessRule, ExternalAddress, LoggingServer, NetworkPeering, Node and stretched PC features
docs: clarified wording around private cloud and update cluster

PiperOrigin-RevId: 599505337

Source-Link: googleapis/googleapis@bf178ab

Source-Link: https://github.com/googleapis/googleapis-gen/commit/ceb9b6ed80a01d7f20f58f7975bfbe056cc35434
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZtd2FyZWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiY2ViOWI2ZWQ4MGEwMWQ3ZjIwZjU4Zjc5NzViZmJlMDU2Y2MzNTQzNCJ9
END_NESTED_COMMIT

…ng, ExternalAccessRule, ExternalAddress, LoggingServer, NetworkPeering, Node and stretched PC features

docs: clarified wording around private cloud and update cluster

PiperOrigin-RevId: 599505337

Source-Link: googleapis/googleapis@bf178ab

Source-Link: googleapis/googleapis-gen@ceb9b6e
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZtd2FyZWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiY2ViOWI2ZWQ4MGEwMWQ3ZjIwZjU4Zjc5NzViZmJlMDU2Y2MzNTQzNCJ9
@dpebot
Copy link
Collaborator

dpebot commented Jan 18, 2024

/gcbrun

@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 18, 2024 18:10
@gcf-owl-bot gcf-owl-bot bot requested review from yoshi-approver and a team as code owners January 18, 2024 18:10
@dpebot
Copy link
Collaborator

dpebot commented Jan 18, 2024

/gcbrun

Copy link

snippet-bot bot commented Jan 18, 2024

Here is the summary of changes.

You are about to add 35 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dpebot
Copy link
Collaborator

dpebot commented Jan 18, 2024

/gcbrun

build: update typescript generator version to 4.3.0

The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.

PiperOrigin-RevId: 599622271

Source-Link: googleapis/googleapis@6239c21

Source-Link: googleapis/googleapis-gen@da13d82
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZtd2FyZWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiZGExM2Q4MjIyZDNiYTMzNzM0NTAxOTk5ODY0NDU4NjQwZjE0MDVhZSJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: [vmwareengine] Adding ManagementDnsZoneBinding, DnsBindPermission, DnsForwarding, ExternalAccessRule, ExternalAddress, LoggingServer, NetworkPeering, Node and stretched PC features fix: [vmwareengine] improve retry logic for streaming API calls Jan 19, 2024
@dpebot
Copy link
Collaborator

dpebot commented Jan 19, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 19, 2024

/gcbrun

@sofisl sofisl merged commit 7d4365f into main Jan 23, 2024
13 checks passed
@sofisl sofisl deleted the owl-bot-copy-packages-google-cloud-vmwareengine branch January 23, 2024 07:21
@release-please release-please bot mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants