-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve retry logic for streaming API calls #4942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData feat: add models to CustomJobSpec feat: add max_wait_duration to Scheduling docs: minor changes to comments PiperOrigin-RevId: 597666793 Source-Link: googleapis/googleapis@84ee19c Source-Link: googleapis/googleapis-gen@8dc3e3e Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjhkYzNlM2UzMjA0M2FjZDY4OTNiZWQ5NmE2YjQ1NjZmMDA4NDMzMjkifQ==
/gcbrun |
…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData feat: add models to CustomJobSpec feat: add max_wait_duration to Scheduling feat: add CountTokens method to llm_utility_service docs: minor changes to comments PiperOrigin-RevId: 597667108 Source-Link: googleapis/googleapis@714ab03 Source-Link: googleapis/googleapis-gen@3ff71b3 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjNmZjcxYjM5ZDJhZDJlZWI1MTEzOTQwYzVkZTU1OTNkYTA1MjdiMjYifQ==
/gcbrun |
gcf-owl-bot
bot
requested review from
yoshi-approver and
a team
as code owners
January 12, 2024 02:05
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
/gcbrun |
…://github.com/googleapis/google-cloud-node into owl-bot-copy-packages-google-cloud-aiplatform
/gcbrun |
…://github.com/googleapis/google-cloud-node into owl-bot-copy-packages-google-cloud-aiplatform
/gcbrun |
…://github.com/googleapis/google-cloud-node into owl-bot-copy-packages-google-cloud-aiplatform
/gcbrun |
/gcbrun |
build: update typescript generator version to 4.3.0 The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update. PiperOrigin-RevId: 599622271 Source-Link: googleapis/googleapis@6239c21 Source-Link: googleapis/googleapis-gen@da13d82 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6ImRhMTNkODIyMmQzYmEzMzczNDUwMTk5OTg2NDQ1ODY0MGYxNDA1YWUifQ==
gcf-owl-bot
bot
changed the title
fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData
fix: improve retry logic for streaming API calls
Jan 19, 2024
/gcbrun |
/gcbrun |
…://github.com/googleapis/google-cloud-node into owl-bot-copy-packages-google-cloud-aiplatform
/gcbrun |
/gcbrun |
sofisl
approved these changes
Jan 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: update typescript generator version to 4.3.0
The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.
PiperOrigin-RevId: 599622271
Source-Link: googleapis/googleapis@6239c21
Source-Link: https://github.com/googleapis/googleapis-gen/commit/da13d8222d3ba33734501999864458640f1405ae
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6ImRhMTNkODIyMmQzYmEzMzczNDUwMTk5OTg2NDQ1ODY0MGYxNDA1YWUifQ==
BEGIN_NESTED_COMMIT
fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData
feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
feat: add CountTokens method to llm_utility_service
docs: minor changes to comments
PiperOrigin-RevId: 597667108
Source-Link: googleapis/googleapis@714ab03
Source-Link: https://github.com/googleapis/googleapis-gen/commit/3ff71b39d2ad2eeb5113940c5de5593da0527b26
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjNmZjcxYjM5ZDJhZDJlZWI1MTEzOTQwYzVkZTU1OTNkYTA1MjdiMjYifQ==
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData
feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
docs: minor changes to comments
PiperOrigin-RevId: 597666793
Source-Link: googleapis/googleapis@84ee19c
Source-Link: https://github.com/googleapis/googleapis-gen/commit/8dc3e3e32043acd6893bed96a6b4566f00843329
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjhkYzNlM2UzMjA0M2FjZDY4OTNiZWQ5NmE2YjQ1NjZmMDA4NDMzMjkifQ==
END_NESTED_COMMIT