Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve retry logic for streaming API calls #4942

Merged
merged 15 commits into from
Jan 23, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 12, 2024

  • Regenerate this pull request now.

build: update typescript generator version to 4.3.0

The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.

PiperOrigin-RevId: 599622271

Source-Link: googleapis/googleapis@6239c21

Source-Link: https://github.com/googleapis/googleapis-gen/commit/da13d8222d3ba33734501999864458640f1405ae
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6ImRhMTNkODIyMmQzYmEzMzczNDUwMTk5OTg2NDQ1ODY0MGYxNDA1YWUifQ==

BEGIN_NESTED_COMMIT
fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData
feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
feat: add CountTokens method to llm_utility_service
docs: minor changes to comments

PiperOrigin-RevId: 597667108

Source-Link: googleapis/googleapis@714ab03

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3ff71b39d2ad2eeb5113940c5de5593da0527b26
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjNmZjcxYjM5ZDJhZDJlZWI1MTEzOTQwYzVkZTU1OTNkYTA1MjdiMjYifQ==
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData
feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
docs: minor changes to comments

PiperOrigin-RevId: 597666793

Source-Link: googleapis/googleapis@84ee19c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8dc3e3e32043acd6893bed96a6b4566f00843329
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjhkYzNlM2UzMjA0M2FjZDY4OTNiZWQ5NmE2YjQ1NjZmMDA4NDMzMjkifQ==
END_NESTED_COMMIT

…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
docs: minor changes to comments

PiperOrigin-RevId: 597666793

Source-Link: googleapis/googleapis@84ee19c

Source-Link: googleapis/googleapis-gen@8dc3e3e
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjhkYzNlM2UzMjA0M2FjZDY4OTNiZWQ5NmE2YjQ1NjZmMDA4NDMzMjkifQ==
@dpebot
Copy link
Collaborator

dpebot commented Jan 12, 2024

/gcbrun

…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
feat: add CountTokens method to llm_utility_service
docs: minor changes to comments

PiperOrigin-RevId: 597667108

Source-Link: googleapis/googleapis@714ab03

Source-Link: googleapis/googleapis-gen@3ff71b3
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6IjNmZjcxYjM5ZDJhZDJlZWI1MTEzOTQwYzVkZTU1OTNkYTA1MjdiMjYifQ==
@dpebot
Copy link
Collaborator

dpebot commented Jan 12, 2024

/gcbrun

@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 12, 2024 02:05
@gcf-owl-bot gcf-owl-bot bot requested review from yoshi-approver and a team as code owners January 12, 2024 02:05
Copy link

snippet-bot bot commented Jan 12, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dpebot
Copy link
Collaborator

dpebot commented Jan 12, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 12, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 12, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 12, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 18, 2024

/gcbrun

build: update typescript generator version to 4.3.0

The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.

PiperOrigin-RevId: 599622271

Source-Link: googleapis/googleapis@6239c21

Source-Link: googleapis/googleapis-gen@da13d82
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFpcGxhdGZvcm0vLk93bEJvdC55YW1sIiwiaCI6ImRhMTNkODIyMmQzYmEzMzczNDUwMTk5OTg2NDQ1ODY0MGYxNDA1YWUifQ==
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData fix: improve retry logic for streaming API calls Jan 19, 2024
@dpebot
Copy link
Collaborator

dpebot commented Jan 19, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 19, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 19, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Jan 23, 2024

/gcbrun

@sofisl sofisl merged commit 0bca99d into main Jan 23, 2024
12 checks passed
@sofisl sofisl deleted the owl-bot-copy-packages-google-cloud-aiplatform branch January 23, 2024 07:32
@release-please release-please bot mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants