Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ai-platform] update typings for helpers, updated docstrings; removed stale comment #4312

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

telpirion
Copy link
Contributor

This PR clarifies the usage of the helpers.

@telpirion telpirion requested review from a team and yoshi-approver as code owners June 2, 2023 18:40
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 2, 2023
@alexander-fenster alexander-fenster changed the title chore: updated docstrings; removed stale comment fix: update typings for helpers, updated docstrings; removed stale comment Jun 2, 2023
@alexander-fenster
Copy link
Contributor

LGTM, please make sure to use the PR title I updated (with the fix:) because otherwise you won't have a release for this change.

@alexander-fenster alexander-fenster requested a review from sofisl June 2, 2023 18:47
@sofisl sofisl changed the title fix: update typings for helpers, updated docstrings; removed stale comment fix: [ai-platform] update typings for helpers, updated docstrings; removed stale comment Jun 6, 2023
@sofisl sofisl added the automerge Merge the pull request once unit tests and other checks pass. label Jun 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit b2c4f46 into main Jun 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the aiplatform-helpers-update branch June 6, 2023 06:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 6, 2023
@release-please release-please bot mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants