Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore: system tests don't run in Node 4.x #2722

Closed
callmehiphop opened this issue Nov 3, 2017 · 2 comments
Closed

datastore: system tests don't run in Node 4.x #2722

callmehiphop opened this issue Nov 3, 2017 · 2 comments
Assignees
Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@callmehiphop
Copy link
Contributor

Environment details

  • OS: Mac OS
  • Node.js version: 4
  • npm version: 3
  • google-cloud-node version: master

Looks like we are using a Buffer method that wasn't added until Node 5. Here's the error:

  1) Datastore create, retrieve and delete should excludeFromIndexes correctly:
     TypeError: Buffer.alloc is not a function
      at Context.<anonymous> (system-test/datastore.js:85:31)
@callmehiphop callmehiphop added api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. testing labels Nov 3, 2017
@lukesneeringer
Copy link
Contributor

lukesneeringer commented Nov 6, 2017

@callmehiphop This one should be easy:

  1. npm install --save-dev safe-buffer

  2. const Buffer = require('safe-buffer').Buffer;

QED

@stephenplusplus stephenplusplus self-assigned this Nov 6, 2017
@callmehiphop
Copy link
Contributor Author

Yeah I know, I came across it while testing/reviewing a different PR and just wanted to make sure it didn't get lost before I could get to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

3 participants