Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCS bucket labels feature #2370

Closed
swcloud opened this issue Jun 9, 2017 · 3 comments
Closed

Add GCS bucket labels feature #2370

swcloud opened this issue Jun 9, 2017 · 3 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@swcloud
Copy link
Contributor

swcloud commented Jun 9, 2017

No description provided.

@swcloud swcloud added the api: storage Issues related to the Cloud Storage API. label Jun 9, 2017
@swcloud swcloud added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jun 9, 2017
@stephenplusplus
Copy link
Contributor

We currently support setting any property of the Bucket resource in storage.createBucket():

storage.createBucket({
  labels: {
    myLabel: 'my label value'
  }
}, function(err, bucket) {})

If a user wants to update the labels, they can use bucket.setMetadata():

bucket.setMetadata({
  labels: {
    myLabel: 'my new label value'
  }
}, function(err) {})

Do we need more than this?

@stephenplusplus
Copy link
Contributor

Got an update on what is wanted:

  • bucket.deleteLabels([labelName, ...], function(err) {})
  • bucket.getLabels(function(err, labels) {})
  • bucket.setLabels({ labelName: 'labelValue' }, function(err) {})

@danoscarmike does this look correct?

@danoscarmike
Copy link
Contributor

Yes, looks right to me. @jskeet for vis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Development

No branches or pull requests

3 participants