From e71327f88e9abc9293faca4a44ca88bd93a663d5 Mon Sep 17 00:00:00 2001 From: Justin Beckwith Date: Tue, 12 Jun 2018 15:27:32 -0700 Subject: [PATCH] fix: drop support for node.js 4.x and 9.x (#97) --- .../google-cloud-compute/.circleci/config.yml | 34 +++++-------------- packages/google-cloud-compute/package.json | 2 +- 2 files changed, 9 insertions(+), 27 deletions(-) diff --git a/packages/google-cloud-compute/.circleci/config.yml b/packages/google-cloud-compute/.circleci/config.yml index a9b7e315489..58598b1944d 100644 --- a/packages/google-cloud-compute/.circleci/config.yml +++ b/packages/google-cloud-compute/.circleci/config.yml @@ -3,32 +3,24 @@ workflows: version: 2 tests: jobs: &workflow_jobs - - node4: + - node6: filters: &all_commits tags: only: /.*/ - - node6: - filters: *all_commits - node8: filters: *all_commits - - node9: - filters: *all_commits - node10: filters: *all_commits - lint: requires: - - node4 - node6 - node8 - - node9 - node10 filters: *all_commits - docs: requires: - - node4 - node6 - node8 - - node9 - node10 filters: *all_commits - system_tests: @@ -62,9 +54,9 @@ workflows: only: master jobs: *workflow_jobs jobs: - node4: + node6: docker: - - image: 'node:4' + - image: 'node:6' user: node steps: &unit_tests_steps - checkout @@ -95,21 +87,11 @@ jobs: name: Submit coverage data to codecov. command: node_modules/.bin/codecov when: always - node6: - docker: - - image: 'node:6' - user: node - steps: *unit_tests_steps node8: docker: - image: 'node:8' user: node steps: *unit_tests_steps - node9: - docker: - - image: 'node:9' - user: node - steps: *unit_tests_steps node10: docker: - image: 'node:10' @@ -117,7 +99,7 @@ jobs: steps: *unit_tests_steps lint: docker: - - image: 'node:8' + - image: 'node:10' user: node steps: - checkout @@ -139,7 +121,7 @@ jobs: NPM_CONFIG_PREFIX: /home/node/.npm-global docs: docker: - - image: 'node:8' + - image: 'node:10' user: node steps: - checkout @@ -150,7 +132,7 @@ jobs: command: npm run docs sample_tests: docker: - - image: 'node:8' + - image: 'node:10' user: node steps: - checkout @@ -177,7 +159,7 @@ jobs: working_directory: /home/node/compute-samples system_tests: docker: - - image: 'node:8' + - image: 'node:10' user: node steps: - checkout @@ -200,7 +182,7 @@ jobs: when: always publish_npm: docker: - - image: 'node:8' + - image: 'node:10' user: node steps: - checkout diff --git a/packages/google-cloud-compute/package.json b/packages/google-cloud-compute/package.json index fc9085db85f..2b11c2cfdb4 100644 --- a/packages/google-cloud-compute/package.json +++ b/packages/google-cloud-compute/package.json @@ -5,7 +5,7 @@ "license": "Apache-2.0", "author": "Google Inc.", "engines": { - "node": ">=4.0.0" + "node": ">=6.0.0" }, "repository": "googleapis/nodejs-compute", "main": "./src/index.js",