fix: do not modify options object, use defaultScopes (#560)

* fix: do not modify options object, use defaultScopes Regenerated the library using gapic-generator-typescript v1.2.1. * fix(deps): require google-gax ^2.9.2
googleapis · Nov 7, 2020 · 3517c9a · 3517c9a
1 parent 09241de
commit 3517c9a
Show file tree

Hide file tree

Showing 6 changed files with 348 additions and 223 deletions.
diff --git a/packages/google-privacy-dlp/package.json b/packages/google-privacy-dlp/package.json
@@ -45,7 +45,7 @@
     "api-documenter": "api-documenter yaml --input-folder=temp"
   },
   "dependencies": {
-    "google-gax": "^2.1.0",
+    "google-gax": "^2.9.2",
     "protobufjs": "^6.8.0"
   },
   "devDependencies": {

diff --git a/packages/google-privacy-dlp/src/index.ts b/packages/google-privacy-dlp/src/index.ts
@@ -19,6 +19,7 @@
 import * as v2 from './v2';
 
 const DlpServiceClient = v2.DlpServiceClient;
+type DlpServiceClient = v2.DlpServiceClient;
 
 export {v2, DlpServiceClient};
 export default {v2, DlpServiceClient};

diff --git a/packages/google-privacy-dlp/src/v2/dlp_service_client.ts b/packages/google-privacy-dlp/src/v2/dlp_service_client.ts
diff --git a/packages/google-privacy-dlp/synth.metadata b/packages/google-privacy-dlp/synth.metadata
@@ -3,23 +3,15 @@
     {
       "git": {
         "name": ".",
-        "remote": "https://github.com/googleapis/nodejs-dlp.git",
-        "sha": "006a73e0e9d38192ba409e1360d8a882bad68f92"
-      }
-    },
-    {
-      "git": {
-        "name": "googleapis",
-        "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "795f0cacce3799e04fa2fe06590216eec4a5ba52",
-        "internalRef": "336694775"
+        "remote": "[email protected]:googleapis/nodejs-dlp.git",
+        "sha": "e675d52e35cfe7bf1355d9ead289891cb2da2db4"
       }
     },
     {
       "git": {
         "name": "synthtool",
         "remote": "https://github.com/googleapis/synthtool.git",
-        "sha": "ba9918cd22874245b55734f57470c719b577e591"
+        "sha": "1f1148d3c7a7a52f0c98077f976bd9b3c948ee2b"
       }
     }
   ],
@@ -87,13 +79,15 @@
     "README.md",
     "api-extractor.json",
     "linkinator.config.json",
+    "package-lock.json.1493547946",
     "protos/google/privacy/dlp/v2/dlp.proto",
     "protos/google/privacy/dlp/v2/storage.proto",
     "protos/protos.d.ts",
     "protos/protos.js",
     "protos/protos.json",
     "renovate.json",
     "samples/README.md",
+    "samples/package-lock.json.701286152",
     "src/index.ts",
     "src/v2/dlp_service_client.ts",
     "src/v2/dlp_service_client_config.json",

diff --git a/packages/google-privacy-dlp/system-test/fixtures/sample/src/index.ts b/packages/google-privacy-dlp/system-test/fixtures/sample/src/index.ts
@@ -18,8 +18,15 @@
 
 import {DlpServiceClient} from '@google-cloud/dlp';
 
+// check that the client class type name can be used
+function doStuffWithDlpServiceClient(client: DlpServiceClient) {
+  client.close();
+}
+
 function main() {
-  new DlpServiceClient();
+  // check that the client instance can be created
+  const dlpServiceClient = new DlpServiceClient();
+  doStuffWithDlpServiceClient(dlpServiceClient);
 }
 
 main();
diff --git a/packages/google-privacy-dlp/system-test/install.ts b/packages/google-privacy-dlp/system-test/install.ts
@@ -20,32 +20,32 @@ import {packNTest} from 'pack-n-play';
 import {readFileSync} from 'fs';
 import {describe, it} from 'mocha';
 
-describe('typescript consumer tests', () => {
-  it('should have correct type signature for typescript users', async function () {
+describe('📦 pack-n-play test', () => {
+  it('TypeScript code', async function () {
     this.timeout(300000);
     const options = {
-      packageDir: process.cwd(), // path to your module.
+      packageDir: process.cwd(),
       sample: {
-        description: 'typescript based user can use the type definitions',
+        description: 'TypeScript user can use the type definitions',
         ts: readFileSync(
           './system-test/fixtures/sample/src/index.ts'
         ).toString(),
       },
     };
-    await packNTest(options); // will throw upon error.
+    await packNTest(options);
   });
 
-  it('should have correct type signature for javascript users', async function () {
+  it('JavaScript code', async function () {
     this.timeout(300000);
     const options = {
-      packageDir: process.cwd(), // path to your module.
+      packageDir: process.cwd(),
       sample: {
-        description: 'typescript based user can use the type definitions',
+        description: 'JavaScript user can use the library',
         ts: readFileSync(
           './system-test/fixtures/sample/src/index.js'
         ).toString(),
       },
     };
-    await packNTest(options); // will throw upon error.
+    await packNTest(options);
   });
 });