diff --git a/packages/google-cloud-secretmanager/.jsdoc.js b/packages/google-cloud-secretmanager/.jsdoc.js index 633f7740082..ec7b139547d 100644 --- a/packages/google-cloud-secretmanager/.jsdoc.js +++ b/packages/google-cloud-secretmanager/.jsdoc.js @@ -40,7 +40,7 @@ module.exports = { includePattern: '\\.js$' }, templates: { - copyright: 'Copyright 2019 Google, LLC.', + copyright: 'Copyright 2020 Google LLC', includeDate: false, sourceFiles: false, systemName: '@google-cloud/secret-manager', diff --git a/packages/google-cloud-secretmanager/.prettierrc.js b/packages/google-cloud-secretmanager/.prettierrc.js index 08cba3775be..d1b95106f4c 100644 --- a/packages/google-cloud-secretmanager/.prettierrc.js +++ b/packages/google-cloud-secretmanager/.prettierrc.js @@ -4,7 +4,7 @@ // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // -// http://www.apache.org/licenses/LICENSE-2.0 +// https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, diff --git a/packages/google-cloud-secretmanager/package.json b/packages/google-cloud-secretmanager/package.json index ea1cfaa3c4a..52cc263e7e3 100644 --- a/packages/google-cloud-secretmanager/package.json +++ b/packages/google-cloud-secretmanager/package.json @@ -26,27 +26,23 @@ "docs": "jsdoc -c .jsdoc.js", "predocs-test": "npm run docs", "docs-test": "linkinator docs", - "fix": "gts fix && eslint samples --fix", - "lint": "gts check && eslint samples", + "fix": "gts fix", + "lint": "gts fix", "prepare": "npm run compile-protos && npm run compile", "system-test": "c8 mocha build/system-test", "test": "c8 mocha build/test", "samples-test": "cd samples/ && npm link ../ && npm test && cd ../", - "prelint": "cd samples; npm link ../; npm i" + "prelint": "cd samples; npm link ../; npm install" }, "dependencies": { - "google-gax": "^2.0.1" + "google-gax": "^2.1.0" }, "devDependencies": { "@types/mocha": "^7.0.0", "@types/node": "^12.0.0", "@types/sinon": "^9.0.0", "c8": "^7.0.0", - "eslint": "^6.0.0", - "eslint-config-prettier": "^6.0.0", - "eslint-plugin-node": "^11.0.0", - "eslint-plugin-prettier": "^3.0.1", - "gts": "2.0.0", + "gts": "^2.0.0", "jsdoc": "^3.5.5", "jsdoc-fresh": "^1.0.1", "jsdoc-region-tag": "^1.0.2", diff --git a/packages/google-cloud-secretmanager/protos/protos.js b/packages/google-cloud-secretmanager/protos/protos.js index de06dfebb27..ab6de7a8b22 100644 --- a/packages/google-cloud-secretmanager/protos/protos.js +++ b/packages/google-cloud-secretmanager/protos/protos.js @@ -28,7 +28,7 @@ var $Reader = $protobuf.Reader, $Writer = $protobuf.Writer, $util = $protobuf.util; // Exported root namespace - var $root = $protobuf.roots["default"] || ($protobuf.roots["default"] = {}); + var $root = $protobuf.roots._google_cloud_secret_manager_3_0_0_protos || ($protobuf.roots._google_cloud_secret_manager_3_0_0_protos = {}); $root.google = (function() { diff --git a/packages/google-cloud-secretmanager/synth.metadata b/packages/google-cloud-secretmanager/synth.metadata index 1ccd3927298..5b3b873c297 100644 --- a/packages/google-cloud-secretmanager/synth.metadata +++ b/packages/google-cloud-secretmanager/synth.metadata @@ -1,19 +1,19 @@ { - "updateTime": "2020-04-02T11:53:11.069823Z", + "updateTime": "2020-04-11T01:32:49.702958Z", "sources": [ { "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "75047719f704d61f405cac6d7439637ab36c1232", - "internalRef": "304305096" + "sha": "1bd77e8ce6f953ac641af7966d0c52646afc16a8", + "internalRef": "305974465" } }, { "git": { "name": "synthtool", "remote": "https://github.com/googleapis/synthtool.git", - "sha": "99820243d348191bc9c634f2b48ddf65096285ed" + "sha": "6f32150677c9784f3c3a7e1949472bd29c9d72c5" } } ], diff --git a/packages/google-cloud-secretmanager/synth.py b/packages/google-cloud-secretmanager/synth.py index 5212f5eda0a..e9aa73ad5a3 100644 --- a/packages/google-cloud-secretmanager/synth.py +++ b/packages/google-cloud-secretmanager/synth.py @@ -55,4 +55,5 @@ # Node.js specific cleanup subprocess.run(['npm', 'install']) -subprocess.run(['npm', 'run', 'fix']) +subprocess.run(['npm', 'run', 'lint']) +subprocess.run(['npx', 'compileProtos', 'src']) diff --git a/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1.ts b/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1.ts index 931d8849dcb..c0e2f2fb37a 100644 --- a/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1.ts +++ b/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1.ts @@ -315,7 +315,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.createSecret(request); }, expectedError); assert( @@ -435,7 +435,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.addSecretVersion(request); }, expectedError); assert( @@ -552,7 +552,7 @@ describe('v1.SecretManagerServiceClient', () => { }; const expectedError = new Error('expected'); client.innerApiCalls.getSecret = stubSimpleCall(undefined, expectedError); - assert.rejects(async () => { + await assert.rejects(async () => { await client.getSecret(request); }, expectedError); assert( @@ -675,7 +675,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.updateSecret(request); }, expectedError); assert( @@ -795,7 +795,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.deleteSecret(request); }, expectedError); assert( @@ -915,7 +915,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.getSecretVersion(request); }, expectedError); assert( @@ -1037,7 +1037,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.accessSecretVersion(request); }, expectedError); assert( @@ -1159,7 +1159,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.disableSecretVersion(request); }, expectedError); assert( @@ -1281,7 +1281,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.enableSecretVersion(request); }, expectedError); assert( @@ -1403,7 +1403,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.destroySecretVersion(request); }, expectedError); assert( @@ -1523,7 +1523,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.setIamPolicy(request); }, expectedError); assert( @@ -1643,7 +1643,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.getIamPolicy(request); }, expectedError); assert( @@ -1765,7 +1765,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.testIamPermissions(request); }, expectedError); assert( @@ -1901,7 +1901,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.listSecrets(request); }, expectedError); assert( @@ -2003,7 +2003,7 @@ describe('v1.SecretManagerServiceClient', () => { reject(err); }); }); - assert.rejects(async () => { + await assert.rejects(async () => { await promise; }, expectedError); assert( @@ -2085,7 +2085,7 @@ describe('v1.SecretManagerServiceClient', () => { expectedError ); const iterable = client.listSecretsAsync(request); - assert.rejects(async () => { + await assert.rejects(async () => { const responses: protos.google.cloud.secretmanager.v1.ISecret[] = []; for await (const resource of iterable) { responses.push(resource!); @@ -2235,7 +2235,7 @@ describe('v1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.listSecretVersions(request); }, expectedError); assert( @@ -2338,7 +2338,7 @@ describe('v1.SecretManagerServiceClient', () => { reject(err); }); }); - assert.rejects(async () => { + await assert.rejects(async () => { await promise; }, expectedError); assert( @@ -2421,7 +2421,7 @@ describe('v1.SecretManagerServiceClient', () => { expectedError ); const iterable = client.listSecretVersionsAsync(request); - assert.rejects(async () => { + await assert.rejects(async () => { const responses: protos.google.cloud.secretmanager.v1.ISecretVersion[] = []; for await (const resource of iterable) { responses.push(resource!); diff --git a/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1beta1.ts b/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1beta1.ts index 57a225e20ed..53314ed598a 100644 --- a/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1beta1.ts +++ b/packages/google-cloud-secretmanager/test/gapic_secret_manager_service_v1beta1.ts @@ -316,7 +316,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.createSecret(request); }, expectedError); assert( @@ -436,7 +436,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.addSecretVersion(request); }, expectedError); assert( @@ -553,7 +553,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { }; const expectedError = new Error('expected'); client.innerApiCalls.getSecret = stubSimpleCall(undefined, expectedError); - assert.rejects(async () => { + await assert.rejects(async () => { await client.getSecret(request); }, expectedError); assert( @@ -676,7 +676,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.updateSecret(request); }, expectedError); assert( @@ -796,7 +796,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.deleteSecret(request); }, expectedError); assert( @@ -916,7 +916,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.getSecretVersion(request); }, expectedError); assert( @@ -1038,7 +1038,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.accessSecretVersion(request); }, expectedError); assert( @@ -1160,7 +1160,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.disableSecretVersion(request); }, expectedError); assert( @@ -1282,7 +1282,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.enableSecretVersion(request); }, expectedError); assert( @@ -1404,7 +1404,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.destroySecretVersion(request); }, expectedError); assert( @@ -1524,7 +1524,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.setIamPolicy(request); }, expectedError); assert( @@ -1644,7 +1644,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.getIamPolicy(request); }, expectedError); assert( @@ -1766,7 +1766,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.testIamPermissions(request); }, expectedError); assert( @@ -1890,7 +1890,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.listSecrets(request); }, expectedError); assert( @@ -1986,7 +1986,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { reject(err); }); }); - assert.rejects(async () => { + await assert.rejects(async () => { await promise; }, expectedError); assert( @@ -2062,7 +2062,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { expectedError ); const iterable = client.listSecretsAsync(request); - assert.rejects(async () => { + await assert.rejects(async () => { const responses: protos.google.cloud.secrets.v1beta1.ISecret[] = []; for await (const resource of iterable) { responses.push(resource!); @@ -2210,7 +2210,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { undefined, expectedError ); - assert.rejects(async () => { + await assert.rejects(async () => { await client.listSecretVersions(request); }, expectedError); assert( @@ -2313,7 +2313,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { reject(err); }); }); - assert.rejects(async () => { + await assert.rejects(async () => { await promise; }, expectedError); assert( @@ -2396,7 +2396,7 @@ describe('v1beta1.SecretManagerServiceClient', () => { expectedError ); const iterable = client.listSecretVersionsAsync(request); - assert.rejects(async () => { + await assert.rejects(async () => { const responses: protos.google.cloud.secrets.v1beta1.ISecretVersion[] = []; for await (const resource of iterable) { responses.push(resource!);