Chain cause in ComputeException.translateAndThrow, add tests #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Changes Unknown when pulling b0446ba on mziccard:compute-add-cause into * on GoogleCloudPlatform:compute-alpha*. |
| assertEquals("message", ex.getMessage()); | ||
| assertFalse(ex.retryable()); | ||
| assertTrue(ex.idempotent()); | ||
| assertEquals(cause, ex.getCause()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
|
@aozarov I just noticed that we do very have different access modifiers for exceptions' constructors. In |
|
Yes, I think consistency here is good and package scope would be a good choice. |
|
Changes Unknown when pulling 678f049 on mziccard:compute-add-cause into * on GoogleCloudPlatform:compute-alpha*. |
mziccard
added a commit
to mziccard/gcloud-java
that referenced
this pull request
Apr 29, 2016
…pis#948) Chain cause in ComputeException.translateAndThrow, add tests and make ComputeException constructors package scoped.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
* CreateFeaturestore Sample API * DeleteFeaturestore Sample API * Create, Update, Get featurestore API's * Revert Code * CreateFeaturestoreSampleTest update * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [4.7.0](googleapis/java-dialogflow@v4.6.0...v4.7.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#941](googleapis/java-dialogflow#941)) ([a1d1971](googleapis/java-dialogflow@a1d1971)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#943](googleapis/java-dialogflow#943)) ([5ea0c35](googleapis/java-dialogflow@5ea0c35)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.0 ([googleapis#939](googleapis/java-dialogflow#939)) ([a199fd4](googleapis/java-dialogflow@a199fd4)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#940](googleapis/java-dialogflow#940)) ([3da152f](googleapis/java-dialogflow@3da152f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/java-aiplatform@v2.9.8...v3.0.0) (2022-07-01) ### ⚠ BREAKING CHANGES * added packaging options for C#, Ruby, and PHP ### Features * add BatchImportModelEvaluationSlices API in aiplatform v1 model_service.proto ([googleapis#972](googleapis/java-aiplatform#972)) ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add BatchImportModelEvaluationSlices API in aiplatform v1beta1 model_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([a2a404f](googleapis/java-aiplatform@a2a404f)) * add ListSavedQueries rpc to aiplatform v1 dataset_service.proto ([googleapis#975](googleapis/java-aiplatform#975)) ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add ListSavedQueries rpc to aiplatform v1beta1 dataset_service.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add model_monitoring_config to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([googleapis#892](googleapis/java-aiplatform#892)) ([a2a404f](googleapis/java-aiplatform@a2a404f)) * add model_version_id to BatchPredictionJob in aiplatform v1 batch_prediction_job.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add model_version_id to DeployedModel in aiplatform v1 endpoint.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add model_version_id to PredictResponse in aiplatform v1 prediction_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add saved_query_id to InputDataConfig in aiplatform v1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add saved_query_id to InputDataConfig in aiplatform v1beta1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add saved_query.proto to aiplatform v1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add saved_query.proto to aiplatform v1beta1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add template_metadata to PipelineJob in aiplatform v1beta1 pipeline_job.proto ([a2a404f](googleapis/java-aiplatform@a2a404f)) * **samples:** add create-featurestore sample ([googleapis#948](googleapis/java-aiplatform#948)) ([ffc4b87](googleapis/java-aiplatform@ffc4b87)) ### Bug Fixes * added packaging options for C#, Ruby, and PHP ([a2a404f](googleapis/java-aiplatform@a2a404f)) * update gapic-generator-java with mock service generation fixes ([googleapis#979](googleapis/java-aiplatform#979)) ([e5f3ca5](googleapis/java-aiplatform@e5f3ca5)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#973](googleapis/java-aiplatform#973)) ([56ad705](googleapis/java-aiplatform@56ad705)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ## [3.6.4](googleapis/java-dlp@v3.6.3...v3.6.4) (2022-08-02) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.120.5 ([#943](googleapis/java-dlp#943)) ([4c7b002](googleapis/java-dlp@4c7b002)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.8 ([#947](googleapis/java-dlp#947)) ([b66f7b1](googleapis/java-dlp@b66f7b1)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#946](googleapis/java-dlp#946)) ([9344629](googleapis/java-dlp@9344629)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
…telligence-bom to v2.2.1 (#948) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-video-intelligence-bom](https://togithub.com/googleapis/java-video-intelligence) | `2.2.0` -> `2.2.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-video-intelligence</summary> ### [`v2.2.1`](https://togithub.com/googleapis/java-video-intelligence/blob/HEAD/CHANGELOG.md#​221-httpsgithubcomgoogleapisjava-video-intelligencecomparev220v221-2022-07-01) [Compare Source](https://togithub.com/googleapis/java-video-intelligence/compare/v2.2.0...v2.2.1) ##### Dependencies - update dependency com.google.cloud:google-cloud-core to v2.8.1 ([#​923](https://togithub.com/googleapis/java-video-intelligence/issues/923)) ([af680c9](https://togithub.com/googleapis/java-video-intelligence/commit/af680c9fb1ceb912facfbfb62299777aa012a184)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
](https://renovatebot.com){kind=link}
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [2.4.8](https://togithub.com/googleapis/java-containeranalysis/compare/v2.4.7...v2.4.8) (2022-10-03) ### Dependencies * Update dependency cachetools to v5 ([#963](https://togithub.com/googleapis/java-containeranalysis/issues/963)) ([f8084b8](https://togithub.com/googleapis/java-containeranalysis/commit/f8084b8ca525fdb265e997894465e4e3a784bd68)) * Update dependency certifi to v2022.9.24 ([#947](https://togithub.com/googleapis/java-containeranalysis/issues/947)) ([2a0becd](https://togithub.com/googleapis/java-containeranalysis/commit/2a0becd99be8825e299a44d4d2946f9c4587aeea)) * Update dependency charset-normalizer to v2.1.1 ([#952](https://togithub.com/googleapis/java-containeranalysis/issues/952)) ([4ac4198](https://togithub.com/googleapis/java-containeranalysis/commit/4ac4198b02c38816cc5279203370e9bcf10ca320)) * Update dependency click to v8.1.3 ([#953](https://togithub.com/googleapis/java-containeranalysis/issues/953)) ([7f2cd56](https://togithub.com/googleapis/java-containeranalysis/commit/7f2cd5655f49d6d2db4519b9096d2800d76eb58a)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#967](https://togithub.com/googleapis/java-containeranalysis/issues/967)) ([44d2acd](https://togithub.com/googleapis/java-containeranalysis/commit/44d2acd1775a20bb678312c063b6edf914dbbc00)) * Update dependency gcp-releasetool to v1.8.8 ([#948](https://togithub.com/googleapis/java-containeranalysis/issues/948)) ([932e614](https://togithub.com/googleapis/java-containeranalysis/commit/932e61468598c1b521806bdd85492aa79c3a5037)) * Update dependency google-api-core to v2.10.1 ([#954](https://togithub.com/googleapis/java-containeranalysis/issues/954)) ([4e0b27c](https://togithub.com/googleapis/java-containeranalysis/commit/4e0b27c3e94b142658a7042b5b66eb85cf07339b)) * Update dependency google-auth to v2.11.1 ([#949](https://togithub.com/googleapis/java-containeranalysis/issues/949)) ([3436e5c](https://togithub.com/googleapis/java-containeranalysis/commit/3436e5c480fd441d9d6544e33f776fa039f5ee7b)) * Update dependency google-cloud-core to v2.3.2 ([#950](https://togithub.com/googleapis/java-containeranalysis/issues/950)) ([cf1a882](https://togithub.com/googleapis/java-containeranalysis/commit/cf1a8823d431d5dfe0a373ee4e9fe25c255e720d)) * Update dependency google-cloud-storage to v2.5.0 ([#955](https://togithub.com/googleapis/java-containeranalysis/issues/955)) ([ff75df9](https://togithub.com/googleapis/java-containeranalysis/commit/ff75df994404a2fc67cac7680d9f7c27c4a53b3f)) * Update dependency google-crc32c to v1.5.0 ([#956](https://togithub.com/googleapis/java-containeranalysis/issues/956)) ([e5d6c21](https://togithub.com/googleapis/java-containeranalysis/commit/e5d6c21d66d4ab2395f27825c19a5b6b6c404baa)) * Update dependency googleapis-common-protos to v1.56.4 ([#951](https://togithub.com/googleapis/java-containeranalysis/issues/951)) ([c0a937f](https://togithub.com/googleapis/java-containeranalysis/commit/c0a937f7dfe786a226361a2a5a7f32a04164c5b6)) * Update dependency markupsafe to v2.1.1 ([#957](https://togithub.com/googleapis/java-containeranalysis/issues/957)) ([8ca520d](https://togithub.com/googleapis/java-containeranalysis/commit/8ca520decf514a494e27cd5b98e2fb427b110c19)) * Update dependency protobuf to v3.20.2 ([#958](https://togithub.com/googleapis/java-containeranalysis/issues/958)) ([e9a5588](https://togithub.com/googleapis/java-containeranalysis/commit/e9a5588dc5bed8d22a2d9b5790005726ca4609f8)) * Update dependency protobuf to v4 ([#964](https://togithub.com/googleapis/java-containeranalysis/issues/964)) ([94ee22e](https://togithub.com/googleapis/java-containeranalysis/commit/94ee22e5cc71f82ffb6f36ba717a6302a725de02)) * Update dependency requests to v2.28.1 ([#960](https://togithub.com/googleapis/java-containeranalysis/issues/960)) ([cb05cff](https://togithub.com/googleapis/java-containeranalysis/commit/cb05cffbe25c60c6f30d46511307031f4cfdc413)) * Update dependency typing-extensions to v4.3.0 ([#961](https://togithub.com/googleapis/java-containeranalysis/issues/961)) ([cf68902](https://togithub.com/googleapis/java-containeranalysis/commit/cf68902904d7a42f8b7d401c2dcf1f357b64bf6c)) * Update dependency zipp to v3.8.1 ([#962](https://togithub.com/googleapis/java-containeranalysis/issues/962)) ([e71d9d1](https://togithub.com/googleapis/java-containeranalysis/commit/e71d9d17af2e6d524029c6490ad4a75efcfbb4f5)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
#948) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 485623855 Source-Link: https://togithub.com/googleapis/googleapis/commit/807125e7953e32535710924fe4bf0362ac93754d Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-auth](https://togithub.com/googleapis/google-auth-library-python) | `==2.11.0` -> `==2.12.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [2.8.17](googleapis/java-core@v2.8.16...v2.8.17) (2022-09-28) ### Dependencies * Update dependency cachetools to v5 ([#943](googleapis/java-core#943)) ([1406c09](googleapis/java-core@1406c09)) * Update dependency certifi to v2022.9.24 ([#934](googleapis/java-core#934)) ([b6e1904](googleapis/java-core@b6e1904)) * Update dependency charset-normalizer to v2.1.1 ([#938](googleapis/java-core#938)) ([ac43d61](googleapis/java-core@ac43d61)) * Update dependency click to v8.1.3 ([#946](googleapis/java-core#946)) ([05fe31f](googleapis/java-core@05fe31f)) * Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.4 ([#945](googleapis/java-core#945)) ([3ebff6f](googleapis/java-core@3ebff6f)) * Update dependency gcp-releasetool to v1.8.8 ([#935](googleapis/java-core#935)) ([0f99ae1](googleapis/java-core@0f99ae1)) * Update dependency google-api-core to v2.10.1 ([#947](googleapis/java-core#947)) ([dedddfe](googleapis/java-core@dedddfe)) * Update dependency google-auth to v2.12.0 ([#948](googleapis/java-core#948)) ([67e53aa](googleapis/java-core@67e53aa)) * Update dependency google-cloud-core to v2.3.2 ([#936](googleapis/java-core#936)) ([a0d2e3e](googleapis/java-core@a0d2e3e)) * Update dependency google-cloud-storage to v2.5.0 ([#949](googleapis/java-core#949)) ([6edc6e3](googleapis/java-core@6edc6e3)) * Update dependency google-crc32c to v1.5.0 ([#950](googleapis/java-core#950)) ([0dda0a2](googleapis/java-core@0dda0a2)) * Update dependency googleapis-common-protos to v1.56.4 ([#937](googleapis/java-core#937)) ([b22a2b1](googleapis/java-core@b22a2b1)) * Update dependency importlib-metadata to v4.12.0 ([#951](googleapis/java-core#951)) ([6abe579](googleapis/java-core@6abe579)) * Update dependency jeepney to v0.8.0 ([#952](googleapis/java-core#952)) ([6a392e8](googleapis/java-core@6a392e8)) * Update dependency jinja2 to v3.1.2 ([#953](googleapis/java-core#953)) ([18a54a7](googleapis/java-core@18a54a7)) * Update dependency keyring to v23.9.3 ([#954](googleapis/java-core#954)) ([5ceabaa](googleapis/java-core@5ceabaa)) * Update dependency markupsafe to v2.1.1 ([#955](googleapis/java-core#955)) ([f64e9bf](googleapis/java-core@f64e9bf)) * Update dependency protobuf to v3.20.2 ([#956](googleapis/java-core#956)) ([fb1aea6](googleapis/java-core@fb1aea6)) * Update dependency protobuf to v4 ([#944](googleapis/java-core#944)) ([6b02535](googleapis/java-core@6b02535)) * Update dependency pyjwt to v2.5.0 ([#939](googleapis/java-core#939)) ([cc8ba46](googleapis/java-core@cc8ba46)) * Update dependency requests to v2.28.1 ([#940](googleapis/java-core#940)) ([ec195e3](googleapis/java-core@ec195e3)) * Update dependency typing-extensions to v4.3.0 ([#941](googleapis/java-core#941)) ([4c414e9](googleapis/java-core@4c414e9)) * Update dependency zipp to v3.8.1 ([#942](googleapis/java-core#942)) ([6dfb0d8](googleapis/java-core@6dfb0d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
…948) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.10` -> `3.21.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.21.12`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.11...v3.21.12) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.11...v3.21.12) ### [`v3.21.11`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.10...v3.21.11) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.10...v3.21.11) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #946 for the compute module