fix: owl-bot-staging should not be commited #8337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts googleapis#8305 which was merged without postprocessor
|
What went wrong here? |
|
The pull request 8305 was merged before OwlBot Post Processor ran. The Post Processor is responsible to extract files from owl-bot-staging directory and to place appropriate locations in the modules. |
|
I missed the part about owlbot prostprocessor not being required being the root cause. |
lqiu96
approved these changes
Sep 9, 2022
suztomo
added a commit
that referenced
this pull request
Sep 19, 2022
…pic, gax_java, generator_java versions (#8340) * Revert "fix: owl-bot-staging should not be commited (#8337)" This reverts commit c9bb4a9. * owlbot-java postprocessor docker run --rm -v $(pwd):/workspace -w /workspace --user $(id -u):$(id -g) gcr.io/cloud-devrel-public-resources/owlbot-java * manual fix * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use shared dep bom without property Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Closed
suztomo
added a commit
to suztomo/google-cloud-java
that referenced
this pull request
Oct 4, 2022
…pic, gax_java, generator_java versions (googleapis#8340) * Revert "fix: owl-bot-staging should not be commited (googleapis#8337)" This reverts commit c9bb4a9. * owlbot-java postprocessor docker run --rm -v $(pwd):/workspace -w /workspace --user $(id -u):$(id -g) gcr.io/cloud-devrel-public-resources/owlbot-java * manual fix * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use shared dep bom without property Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #8305
which was merged without postprocessor