-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Datastore - Entity Count Query - StructuredQuery.Builder - Allow limit of 0 #6263
Labels
api: datastore
Issues related to the Datastore API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
@codeconsole thanks, I checked the document again and it says limit >=0 |
@ajaaym That's an even better reference ;) |
@codeconsole yeah we will have PR soon. |
sweet! thanks! |
This was referenced Sep 17, 2019
Thanks guys, Any chance on adding null value binding support to Gql query? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: datastore
Issues related to the Datastore API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
This API should be feature comparable to the standard API. 1 such feature that is missing is a count query which can very easily be implemented according to this ticket that was just closed:
#5061
All that is necessary is 1 of 3 things.
Don't implement it, but allow a user workaround by allowing setting a limit of 0. Why not? You can do it with other APIs.
Implement it as described in the above ticket (which works), add a count method, and maintain the exception of no allowing limits of 0.
Do both.
Either way, I don't quite understand the special java implementation that throws and exception with a limit of 0 is set considering this serves a purpose and is allowed by other APIs.
The text was updated successfully, but these errors were encountered: