Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Datastore - Entity Count Query - StructuredQuery.Builder - Allow limit of 0 #6263

Closed
codeconsole opened this issue Sep 12, 2019 · 5 comments · Fixed by #6292
Closed
Assignees
Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@codeconsole
Copy link

This API should be feature comparable to the standard API. 1 such feature that is missing is a count query which can very easily be implemented according to this ticket that was just closed:

#5061

All that is necessary is 1 of 3 things.

  1. Don't implement it, but allow a user workaround by allowing setting a limit of 0. Why not? You can do it with other APIs.

  2. Implement it as described in the above ticket (which works), add a count method, and maintain the exception of no allowing limits of 0.

  3. Do both.

Either way, I don't quite understand the special java implementation that throws and exception with a limit of 0 is set considering this serves a purpose and is allowed by other APIs.

@ajaaym ajaaym added api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 12, 2019
@athakor athakor self-assigned this Sep 12, 2019
@ajaaym
Copy link
Contributor

ajaaym commented Sep 12, 2019

@codeconsole thanks, I checked the document again and it says limit >=0

@codeconsole
Copy link
Author

@ajaaym That's an even better reference ;)
So is it possible that we can get the Java API to reflect this?

@ajaaym
Copy link
Contributor

ajaaym commented Sep 12, 2019

@codeconsole yeah we will have PR soon.

@codeconsole
Copy link
Author

sweet! thanks!

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 13, 2019
@athakor athakor removed the triage me I really want to be triaged. label Sep 14, 2019
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 14, 2019
@athakor athakor removed the triage me I really want to be triaged. label Sep 14, 2019
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 14, 2019
@athakor athakor added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Sep 14, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Sep 19, 2019
@ajaaym ajaaym removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Sep 19, 2019
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Sep 19, 2019
@ajaaym ajaaym removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Sep 19, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Sep 19, 2019
@athakor athakor added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Sep 20, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Sep 20, 2019
@codeconsole
Copy link
Author

Thanks guys,

Any chance on adding null value binding support to Gql query?

#6357

@chingor13
@athakor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
4 participants