Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatastoreOptions.Builder#namespace(String) should be setNamespace #1353

Closed
sai-pullabhotla opened this issue Oct 31, 2016 · 1 comment
Closed

DatastoreOptions.Builder#namespace(String) should be setNamespace #1353

sai-pullabhotla opened this issue Oct 31, 2016 · 1 comment
Assignees
@mziccard

Comments

@sai-pullabhotla
Copy link

Just like how there is setProjectId(String), setAuthCredentials(AuthCredentials), need setNamespace(String) for consistency. Deprecate the namespace(String) method.
@mziccard
Copy link
Contributor

You are totally right, we missed this. I'll fix ASAP, thanks for the report.

@mziccard mziccard mentioned this issue Oct 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mziccard mziccard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mziccard @sai-pullabhotla