Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction.Response - Both generatedKeys() and getGeneratedKeys() are marked as deprecated #1351

Closed
sai-pullabhotla opened this issue Oct 31, 2016 · 2 comments
Assignees

Comments

@sai-pullabhotla
Copy link

In the Datastore API 0.5.0, in Transaction.Response interface - Both generatedKeys() and getGeneratedKeys() are marked as deprecated. What is the alternative? I wonder if the new method getGeneratedKeys was unintentionally marked as deprecated?

public interface Transaction extends DatastoreBatchWriter, DatastoreReaderWriter {

  interface Response {
    /**
     * Returns a list of keys generated by a transaction.
     */
    @Deprecated
    List<Key> generatedKeys();

    /**
     * Returns a list of keys generated by a transaction.
     */
    @Deprecated
    List<Key> getGeneratedKeys();
  }
//...
}

@mziccard
Copy link
Contributor

@sai-pullabhotla Thanks for this report. This is clearly an error on our side, getGeneratedKeys should not be deprecated. I'll fix this ASAP.

@mziccard
Copy link
Contributor

mziccard commented Nov 1, 2016

Fixed with #1358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants