Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does google-cloud-resourcemanager have a grpc-s2a dependency? #11324

Closed
ejona86 opened this issue Nov 21, 2024 · 2 comments
Closed

How does google-cloud-resourcemanager have a grpc-s2a dependency? #11324

ejona86 opened this issue Nov 21, 2024 · 2 comments

Comments

@ejona86
Copy link

ejona86 commented Nov 21, 2024

In grpc/grpc-java#11703 we noticed google-cloud-resourcemanager 1.56.0 has a dependency on the new grpc artifact grpc-s2a.

I was surprised to see such a dependency, so I was looking at the source in this repo, and I don't understand how/why that dependency exists. The POM in this repository is substantially different than the POM on Maven Central, and it doesn't have an s2a dependency.

Everything could be fine, but it seems weird things are going on.

@suztomo
Copy link
Member

suztomo commented Nov 22, 2024

About the mystery of pom.xml file, we use flatten-maven-plugin https://www.mojohaus.org/flatten-maven-plugin/flatten-mojo.html. It moves the transitive dependencies to direct dependencies when we release Maven artifacts.

@ejona86
Copy link
Author

ejona86 commented Nov 22, 2024

With that in mind, mvn dependency:tree shows:

...
[INFO] +- com.google.api:gax-grpc:jar:2.58.0:compile
[INFO] |  +- io.grpc:grpc-inprocess:jar:1.68.1:compile
[INFO] |  |  \- io.grpc:grpc-core:jar:1.68.1:compile
[INFO] |  |     +- com.google.android:annotations:jar:4.1.1.4:runtime
[INFO] |  |     \- org.codehaus.mojo:animal-sniffer-annotations:jar:1.24:runtime
[INFO] |  +- io.grpc:grpc-alts:jar:1.68.1:compile
[INFO] |  |  +- io.grpc:grpc-grpclb:jar:1.68.1:compile
[INFO] |  |  \- org.conscrypt:conscrypt-openjdk-uber:jar:2.5.2:compile
[INFO] |  +- io.grpc:grpc-auth:jar:1.68.1:compile
[INFO] |  +- io.grpc:grpc-s2a:jar:1.68.1:compile
...

And that led me to googleapis/sdk-platform-java#3326. Thank you.

@ejona86 ejona86 closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants