From b613571e7abe03770cb777e28b11ea25c23f054c Mon Sep 17 00:00:00 2001 From: Fernando Urbano Date: Thu, 29 Aug 2024 20:33:42 +0900 Subject: [PATCH 1/2] defaults to 60 --- pubsub/subscription.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pubsub/subscription.go b/pubsub/subscription.go index c6311d6e933b..92f13b9313e0 100644 --- a/pubsub/subscription.go +++ b/pubsub/subscription.go @@ -899,8 +899,7 @@ type ReceiveSettings struct { // // MinExtensionPeriod must be between 10s and 600s (inclusive). This configuration // can be disabled by specifying a duration less than (or equal to) 0. - // Defaults to off but set to 60 seconds if the subscription has exactly-once delivery enabled, - // which will be added in a future release. + // Defaults to off but set to 60 seconds if the subscription has exactly-once delivery enabled. MinExtensionPeriod time.Duration // MaxOutstandingMessages is the maximum number of unprocessed messages From 31a811f2850d6b77e9bf1d9b2625e74d90f70ee0 Mon Sep 17 00:00:00 2001 From: Alex Hong <9397363+hongalex@users.noreply.github.com> Date: Fri, 6 Sep 2024 15:40:56 -0700 Subject: [PATCH 2/2] update comment to clarify it is disabled --- pubsub/subscription.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pubsub/subscription.go b/pubsub/subscription.go index 92f13b9313e0..9e99e60f2fb6 100644 --- a/pubsub/subscription.go +++ b/pubsub/subscription.go @@ -899,7 +899,7 @@ type ReceiveSettings struct { // // MinExtensionPeriod must be between 10s and 600s (inclusive). This configuration // can be disabled by specifying a duration less than (or equal to) 0. - // Defaults to off but set to 60 seconds if the subscription has exactly-once delivery enabled. + // Disabled by default but set to 60 seconds if the subscription has exactly-once delivery enabled. MinExtensionPeriod time.Duration // MaxOutstandingMessages is the maximum number of unprocessed messages