Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: TestIntegration_UpdateEventBasedHold failed #9701

Closed
flaky-bot bot opened this issue Apr 4, 2024 · 3 comments · Fixed by #10516
Closed

storage: TestIntegration_UpdateEventBasedHold failed #9701

flaky-bot bot opened this issue Apr 4, 2024 · 3 comments · Fixed by #10516
Assignees
@BrennaEpp
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Apr 4, 2024

Note: #8067 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: b3132c1
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. labels Apr 4, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented Apr 4, 2024

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (b3132c1), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 4, 2024
@BrennaEpp
Copy link
Contributor 

=== RUN   TestIntegration_UpdateEventBasedHold/http
    integration_test.go:3806: update: googleapi: Error 412: At least one of the pre-conditions you specified did not hold., conditionNotMet

@BrennaEpp BrennaEpp added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 5, 2024
@BrennaEpp
Copy link
Contributor

I believe the update retry is working and seeing this error because of the retry. I will update the func to not fail on precondition failure.

@BrennaEpp BrennaEpp assigned BrennaEpp and unassigned tritone Jul 6, 2024
@BrennaEpp BrennaEpp mentioned this issue Jul 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrennaEpp BrennaEpp

Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(storage): mustUpdateObject does not fail on precondition failure BrennaEpp/google-cloud-go
2 participants
@tritone @BrennaEpp