Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: third party dependency exception for github.com/cloudprober/cloudprober #9377

Closed
noahdietz opened this issue Feb 6, 2024 · 1 comment
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.

Comments

@noahdietz
Copy link
Contributor

Module: storage/internal/benchmarks
Usage(s): storage/internal/benchmarks/main.go

For the time being, it will be exempt from the third party dep check, but please do one of the following:

A. Remove the dependency by switching to a package own directly by Google, handwriting necessary functionality, or using stdlib
B. Justify the exception and ack the risks, maintaining the exception indefinitely

@noahdietz noahdietz added the type: process A process-related concern. May include testing, release, or the like. label Feb 6, 2024
@noahdietz noahdietz self-assigned this Feb 6, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 6, 2024
@noahdietz
Copy link
Contributor Author

Exempting indefinitely via option B.

This is an internal only module that end users will not interact with and is module-separated from the actual client library. There shouldn't be a concern here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

1 participant