-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): enable REGAPIC and REST numeric enums #6999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for simplifying the config! 🎉
product-auto-label
bot
added
size: xl
Pull request size is extra large.
and removed
size: m
Pull request size is medium.
labels
Dec 6, 2022
noahdietz
force-pushed
the
regapic-enablement
branch
from
December 6, 2022 22:14
6c27272
to
3b15da5
Compare
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: xl
Pull request size is extra large.
labels
Dec 6, 2022
I regenerated everything, pushed it to this PR, and |
noahdietz
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 7, 2022
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 7, 2022
product-auto-label
bot
added
the
stale: old
Pull request is old and needs attention.
label
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables REGAPIC and REST numeric enum serialization for all API clients, except for those that are known to only support one transport / not support REST numeric enum serialization.
["grpc", "rest"]
is now the default set of transports generated for a package. REST numeric enum serialization is enabled by default. As such, this removes all explicitTransports
instances that match the new default.Note: There are three beta-level packages that will take breaking changes in a follow-up PR that remove REST support.