fix(pubsub): enable updating enable_exactly_once_delivery in fake pubsub #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
Fixes #5939 |
hongalex
approved these changes
Apr 25, 2022
|
Thanks for opening this PR! If you could sign the CLA, I can get this merged in. |
Just signed it, thanks! |
hongalex
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client
PubSub
Go Environment
go version go1.17.1 linux/amd64
Description
The testing fake pubsub implementation does not yet support the new enable_exactly_once_delivery field in the UpdateSubscription method.
Expected behavior
When a Subscription is updated to set EnableExactlyOnceDelivery with UpdateSubscription, the RPC should not return an error and the subscription should be modified.
Actual behavior
The RPC returns InvalidArgument with: unknown field name "enable_exactly_once_delivery"