fix(pubsub): nack messages properly with error from receive scheduler #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a change made in #4733 which was supposed to prevent errors in the receive scheduler from bubbling up to user code (when the user had no control over this behavior). Specifically, when
Shutdownis called on the receive scheduler and new messages come in, draining errors were being returned to the user. The limitation of #4733 is that the shutdown signal wasn't being used at all and messages might be added to the scheduler even after shutdown is called. This is not a user reported issue, just something I noticed when I was reading throughreceive_scheduler.go.Fixes #5911