Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): Query.Read fails with dry-run queries #5753

Merged

Conversation

NoelM
Copy link
Contributor

@NoelM NoelM commented Mar 14, 2022

Fixes #5752. Query.Read must fail with dry-run queries, as the documentation mentions

To be aligned with documentation (see line 125), Query.Read must fail
with dry-run queries
@NoelM NoelM requested a review from a team March 14, 2022 16:09
@NoelM NoelM requested a review from a team as a code owner March 14, 2022 16:09
@NoelM NoelM requested a review from steffnay March 14, 2022 16:09
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the BigQuery API. labels Mar 14, 2022
@google-cla
Copy link

google-cla bot commented Mar 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@shollyman shollyman requested review from shollyman and removed request for steffnay March 14, 2022 16:17
@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2022
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@shollyman shollyman enabled auto-merge (squash) March 14, 2022 16:36
@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2022
@shollyman shollyman merged commit e279584 into googleapis:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery: query.Read does not fail on dry-run queries, but evaluates them
3 participants