Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add support of PGNumeric with integration tests for PG dialect #5700

Merged
merged 7 commits into from
Mar 2, 2022
Merged

feat(spanner): add support of PGNumeric with integration tests for PG dialect #5700

merged 7 commits into from
Mar 2, 2022

Conversation

rahul2393
Copy link
Contributor

Two changes:

  • PGNumeric support
  • Integration tests with PG dialect

@rahul2393 rahul2393 requested review from a team as code owners February 25, 2022 10:07
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the Spanner API. labels Feb 25, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@rahul2393 rahul2393 closed this Feb 25, 2022
@rahul2393 rahul2393 reopened this Feb 25, 2022
@rahul2393 rahul2393 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2022
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hengfengli
Copy link
Contributor

hengfengli commented Feb 27, 2022

@rahul2393 For the TestKey test, can we fix the test instead of skipping it? Do we know why it fails?

Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the TestKey test for PG?

@rahul2393 rahul2393 merged commit f7e02e1 into googleapis:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants