go spanner wrapper not backwards-compatible with spanner driver wrt session management in aborted transactions

[epot]

Client

Spanner

Environment

Alpine Docker on GKE
go 1.23.3

Code and Dependencies

package main

func main() {
  // this is using cirello.io/dynamolock/[email protected] library
  lock, err := l.lockClient.AcquireLockWithContext(
	ctx, "test",
	dynamolock.WithAdditionalTimeToWaitForLock(l.leasePeriod),
	dynamolock.WithData([]byte(l.selfValue)),
	dynamolock.ReplaceData())
}

go.mod

module modname

go 1.23.0

require (
	github.com/googleapis/go-sql-spanner v1.7.4
	cloud.google.com/go/spanner v1.73.0
...
)

Expected behavior

It has been working fine for a long time.

Actual behavior

We started to see a few panics since we upgraded the client from v1.70.0 to v1.73.0.

Screenshots

Additional context

It seems strangely familiar with #10385, I wonder if another regression was introduced?

[ella-chao]

So what we found is that go-sql-spanner v1.7.4 is incompatible with spanner v1.73.0 with regards to session handling for aborted transactions.

The screenshot above shows that the transaction was aborted and rollback is called, which eventually accesses the session handle here. However, the session handle has already been nullified here.

We are upgrading go-sql-spanner to v1.9.0 to pick up this change which will create another session handle, but wanted to get your thoughts on this as the PR that introduced the session handle nullification mentioned session reuse for aborted transactions.

[epot]

I updated the title following Ella's findings.