spanner: failed to NewClient WithCredentialsJSON, might be caused by newBuiltinMetricsTracerFactory

[RainbowDashy]

Client

spanner

Environment

go 1.23.2

Code and Dependencies

package spanner_test

import (
	"context"
	"log"
	"testing"

	"cloud.google.com/go/spanner"
	"google.golang.org/api/option"
)

func TestConnect(t *testing.T) {
	ctx := context.Background()
	j := "<service account key in json format>"
	_, err := spanner.NewClient(ctx, "projects/foo/instances/bar/databases/d", option.WithCredentialsJSON([]byte(j)))
	if err != nil {
		log.Fatal(err)
	}
}

go.mod

module modname

go 1.23.2

require (
   	cloud.google.com/go/spanner v1.71.0
)

Expected behavior

I expect no error. But I get the error
credentials: could not find default credentials. See https://cloud.google.com/docs/authentication/external/set-up-adc for more information.

With some debugging, I found out that the error is returned by newBuiltinMetricsTracerFactory at L510.

google-cloud-go/spanner/client.go

Line 510 in f06a55a

metricsTracerFactory, err := newBuiltinMetricsTracerFactory(ctx, database, metricsProvider, config.Compression, opts...)

It seems to me that the problem is newBuiltinMetricsTracerFactory doesn't respect the WithCredentialsJSON option.

[GavinFrazar]

I ran into this in test code as well and worked around it by just disabling metrics:

	clientCfg := spanner.ClientConfig{
		DisableNativeMetrics: true,
		SessionPoolConfig:    spanner.DefaultSessionPoolConfig,
	}
	clt, err := spanner.NewClientWithConfig(ctx, databaseID, clientCfg, opts...)

[rahul2393]

@RainbowDashy @GavinFrazar Can you please check if v1.73.0 already fixes this?
PR: #11109

[GavinFrazar]

@RainbowDashy @GavinFrazar Can you please check if v1.73.0 already fixes this? PR: #11109

I can confirm that v1.73.0 fixed my tests without disabling the metrics.

Thanks!