Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add universe domain support to mTLS #11159

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Nov 20, 2024

  • Remove runtime error for mTLS usage with non-GDU universe domain
  • Add UNIVERSE_DOMAIN placeholder support for Options.DefaultMTLSEndpoint

refs: googleapis/google-api-go-client#2880

* Remove EXPERIMENTAL field DefaultMTLSEndpoint from httptransport.InternalOptions
* Add EXPERIMENTAL field DefaultMTLSEndpointTemplate to httptransport.InternalOptions
* Remove EXPERIMENTAL field DefaultMTLSEndpoint from grpctransport.InternalOptions
* Add EXPERIMENTAL field DefaultMTLSEndpointTemplate to grpctransport.InternalOptions
* Remove runtime error for mTLS usage with non-GDU universe domain.

refs: googleapis/google-api-go-client#2880
@quartzmo quartzmo force-pushed the auth-mtls-universe-domain branch from 812bcbe to 71ec6ca Compare November 20, 2024 17:01
@quartzmo quartzmo marked this pull request as ready for review November 21, 2024 20:33
@quartzmo quartzmo requested a review from a team as a code owner November 21, 2024 20:33
@quartzmo quartzmo merged commit 117748b into main Nov 21, 2024
8 checks passed
@quartzmo quartzmo deleted the auth-mtls-universe-domain branch November 21, 2024 21:31
Copy link
Member

@viacheslav-rostovtsev viacheslav-rostovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants